From 91488dd4b33b00c32f73c305ddc7858588135149 Mon Sep 17 00:00:00 2001 From: Elad Motola Date: Tue, 6 Oct 2020 20:28:53 +0300 Subject: [PATCH 1/3] [test] Migrate CssBaseline to react-testing-library --- .../material-ui/src/CssBaseline/CssBaseline.test.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/material-ui/src/CssBaseline/CssBaseline.test.js b/packages/material-ui/src/CssBaseline/CssBaseline.test.js index 5913465e772f0c..0a0f7d470d9cbe 100644 --- a/packages/material-ui/src/CssBaseline/CssBaseline.test.js +++ b/packages/material-ui/src/CssBaseline/CssBaseline.test.js @@ -1,19 +1,22 @@ import * as React from 'react'; import { expect } from 'chai'; -import { createMount } from 'test/utils'; +import { createClientRender } from 'test/utils'; import CssBaseline from './CssBaseline'; describe('', () => { // StrictModeViolation: makeStyles will retain the styles in the head in strict mode // which becomes an issue for global styles - const mount = createMount({ strict: false }); + const render = createClientRender(); it('renders its children', () => { - const wrapper = mount( + const { container } = render(
, ); - expect(wrapper.find('#child').type()).to.equal('div'); + + const child = container.querySelector('#child'); + + expect(child.tagName).to.equal('DIV'); }); }); From 0627ef5704a952fbe1f803a9d51ae53393032649 Mon Sep 17 00:00:00 2001 From: Elad Motola Date: Tue, 6 Oct 2020 20:49:04 +0300 Subject: [PATCH 2/3] rerun CI From 1007f2fba32ae27a71a6a31a7f847d5f35624218 Mon Sep 17 00:00:00 2001 From: Elad Motola Date: Wed, 7 Oct 2020 14:18:58 +0300 Subject: [PATCH 3/3] try with strict:false --- packages/material-ui/src/CssBaseline/CssBaseline.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/material-ui/src/CssBaseline/CssBaseline.test.js b/packages/material-ui/src/CssBaseline/CssBaseline.test.js index 0a0f7d470d9cbe..b57b974c806b38 100644 --- a/packages/material-ui/src/CssBaseline/CssBaseline.test.js +++ b/packages/material-ui/src/CssBaseline/CssBaseline.test.js @@ -6,7 +6,7 @@ import CssBaseline from './CssBaseline'; describe('', () => { // StrictModeViolation: makeStyles will retain the styles in the head in strict mode // which becomes an issue for global styles - const render = createClientRender(); + const render = createClientRender({ strict: false }); it('renders its children', () => { const { container } = render(