[ButtonBase] Better keyboard focused story #11090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classes
object was cascading between the different elements. It does not! I took a strong implementation bias by not allowing it.The CSS is already cascading, having the same behavior for the
classes
property would have made debugging much harder. I believe I have fixed all the definitions cc @pelotomBreaking change
keyboardFocused
featurefocusVisible
in order to follow the CSS specification wording:https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
classes
property to host the focus visible feature. The fact that the classes don't cascade was making it hard to use. Instead, we rely on afocusVisibleClassName
property. This is allowing any component along the rendering chain to use the feature. For instance, a Switch component: Switch > SwitchBase > IconButton > ButtonBase.Closes #10976