Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Add Danish (da-DK) locale #29485

Merged
merged 5 commits into from
Dec 18, 2021
Merged

[l10n] Add Danish (da-DK) locale #29485

merged 5 commits into from
Dec 18, 2021

Conversation

mikk5829
Copy link
Contributor

@mikk5829 mikk5829 commented Nov 3, 2021

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 3, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against afee13d

@mbrookes mbrookes added localization l10n localization and removed localization labels Nov 3, 2021
@mbrookes

This comment has been minimized.

Sign in to view
@mbrookes mbrookes changed the title Updating with danish language [l10n] Add Danish language strings Nov 20, 2021
@oliviertassinari oliviertassinari added the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Nov 22, 2021
@oliviertassinari
Copy link
Member

Closing for the same reason as #27520.

IMG_20211122_110940

Thanks for the suggestion.

@mikk5829
Copy link
Contributor Author

@oliviertassinari That is some weird rejection, since the pr is basically free

@mbrookes
Copy link
Member

Danish and Norwegian are in the top 33 languages used on the web: https://w3techs.com/technologies/overview/content_language

@mbrookes mbrookes removed the out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) label Nov 25, 2021
@mbrookes mbrookes reopened this Nov 25, 2021
@mbrookes mbrookes mentioned this pull request Nov 25, 2021
Merged
1 task
michaldudak
michaldudak reviewed Dec 15, 2021
View reviewed changes
dangerfile2.js Outdated
@@ -0,0 +1,160 @@
// inspire by reacts dangerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbrookes has this file been added by accident?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears so

@oliviertassinari oliviertassinari changed the title [l10n] Add Danish language strings [l10n] Add Danish (da-DK) locale Dec 15, 2021
@mbrookes mbrookes merged commit 6af5ac9 into mui:master Dec 18, 2021
@mbrookes
Copy link
Member

@mikk5829 Thanks. Sorry for the back-and-forth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikk5829 @mui-pr-bot @mbrookes @oliviertassinari @michaldudak