Removing the hash change on album close (#97)

* Removing the hash change on album close * Fixing upload artifact version
msaperst · Feb 26, 2025 · d40fbfb · d40fbfb
1 parent b5aa4d3
commit d40fbfb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/api-test.yml b/.github/workflows/api-test.yml
@@ -74,7 +74,7 @@ jobs:
 
       - name: Upload Coverage 📊
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: API Results
           path: reports
diff --git a/.github/workflows/code-test.yml b/.github/workflows/code-test.yml
@@ -29,7 +29,7 @@ jobs:
 
       - name: Upload Coverage 📊
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ut-coverage
           path: reports
@@ -99,7 +99,7 @@ jobs:
 
       - name: Upload Coverage 📊
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: it-coverage
           path: reports

diff --git a/.github/workflows/dependency-checks.yml b/.github/workflows/dependency-checks.yml
@@ -45,7 +45,7 @@ jobs:
 
       - name: Publish Result 📊
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: OWASP Dependency Check Results
           path: reports
diff --git a/public/js/album.js b/public/js/album.js
@@ -25,7 +25,7 @@ function Album(albumId, columns, totalImages) {
     };
 
     $('#album').on('hide.bs.modal', function () {
-        window.location.hash = "";
+        history.pushState("", document.title, window.location.pathname + window.location.search);
     });
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,7 +25,7 @@ function Album(albumId, columns, totalImages) { @@
         };
         $('#album').on('hide.bs.modal', function () {
-            window.location.hash = "";
+            history.pushState("", document.title, window.location.pathname + window.location.search);
         });
     }
@@ Expand Down @@