Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released version missing in github tags #67

Closed
sshedi opened this issue Sep 16, 2022 · 12 comments
Closed

Released version missing in github tags #67

sshedi opened this issue Sep 16, 2022 · 12 comments

Comments

@sshedi
Copy link

sshedi commented Sep 16, 2022

Hi @msabramo,

I see that https://pypi.org/project/requests-unixsocket/#history has v0.3.0 but github tags has only 0.2.0 as latest.
Is there anything missing or is this intentional? Can you please give some more details on the same?

@grawlinson
Copy link

Chiming in to mention that new tags would be ideal. :)

@sshedi
Copy link
Author

sshedi commented Nov 6, 2022

@grawlinson I didn't get your comment, can you explain more?

@grawlinson
Copy link

I maintain python-requests-unixsocket on Arch Linux and I would prefer to be able to grab the source from GitHub rather than PyPi. Hence the request for git tags for >0.2.0.

@sshedi
Copy link
Author

sshedi commented Nov 7, 2022

Having mismatched versions in official upstream repo and pypi makes things look suspicious and complicates things unnecessarily.

@kloczek
Copy link

kloczek commented Apr 15, 2023

+1 .. please.
(My automation is using git tags 😞 )

@wuch-g2v
Copy link

ping ..

@kloczek
Copy link

kloczek commented Apr 5, 2024

gentle ping .. 🤔

@webknjaz
Copy link
Collaborator

webknjaz commented Feb 3, 2025

It was published on Dec 24, 2021. So it's most likely this commit: 8449bc0. Just need to download the dists and attempt to match the contents to code to be sure. Then, we can just create that tag manually.

Originally posted by @webknjaz in #74

@webknjaz webknjaz marked this as a duplicate of #74 Feb 3, 2025
@webknjaz
Copy link
Collaborator

webknjaz commented Feb 6, 2025

UPD: I've downloaded the sdist, the wheel and a checkout of 8449bc0 locally for comparison. There's small difference between the dists and 8449bc0 — a few meaningless config changes like indentation. And also, the sdist includes a file with the list of authors and a "change log" extracted from Git history — these were generated by pbr (https://docs.openstack.org/pbr/3.1.1/index.html#what-it-does).

$ diff -ur 8449bc0/ old/wheel/requests_unixsocket-0.3.0/ 
Only in 8449bc0/: examples
Only in 8449bc0/: .git
Only in 8449bc0/: .github
Only in 8449bc0/: .gitignore
Only in 8449bc0/: LICENSE
Only in 8449bc0/: Makefile
Only in 8449bc0/: pytest.ini
Only in 8449bc0/: .python-version
Only in 8449bc0/: README.rst
Only in old/wheel/requests_unixsocket-0.3.0/: requests_unixsocket-0.3.0.dist-info
Only in 8449bc0/: requirements.txt
Only in 8449bc0/: setup.cfg
Only in 8449bc0/: setup.py
Only in 8449bc0/: test-requirements.txt
Only in 8449bc0/: tox.ini

$ diff -ur 8449bc0/ old/sdist/requests-unixsocket-0.3.0/ 
Only in old/sdist/requests-unixsocket-0.3.0/: AUTHORS
Only in old/sdist/requests-unixsocket-0.3.0/: ChangeLog
Only in 8449bc0/: .git
Only in 8449bc0/: .gitignore
Only in old/sdist/requests-unixsocket-0.3.0/: PKG-INFO
Only in old/sdist/requests-unixsocket-0.3.0/: requests_unixsocket.egg-info
diff --color -ur 8449bc0/setup.cfg old/sdist/requests-unixsocket-0.3.0/setup.cfg
--- 8449bc0/setup.cfg	2025-02-06 10:32:22.168025329 +0100
+++ old/sdist/requests-unixsocket-0.3.0/setup.cfg	2021-12-24 02:37:14.484028300 +0100
@@ -6,21 +6,20 @@
 description_file = README.rst
 license = Apache-2
 home_page = https://github.com/msabramo/requests-unixsocket
-# home_page = https://requests-unixsocket.readthedocs.org/
-classifier =
-    Development Status :: 3 - Alpha
-    Intended Audience :: Developers
-    Intended Audience :: Information Technology
-    License :: OSI Approved :: Apache Software License
-    Operating System :: OS Independent
-    Programming Language :: Python
-    Programming Language :: Python :: 2
-    Programming Language :: Python :: 2.7
-    Programming Language :: Python :: 3
-    Programming Language :: Python :: 3.3
-    Programming Language :: Python :: 3.4
-    Programming Language :: Python :: 3.5
-    Programming Language :: Python :: 3.6
+classifier = 
+	Development Status :: 3 - Alpha
+	Intended Audience :: Developers
+	Intended Audience :: Information Technology
+	License :: OSI Approved :: Apache Software License
+	Operating System :: OS Independent
+	Programming Language :: Python
+	Programming Language :: Python :: 2
+	Programming Language :: Python :: 2.7
+	Programming Language :: Python :: 3
+	Programming Language :: Python :: 3.3
+	Programming Language :: Python :: 3.4
+	Programming Language :: Python :: 3.5
+	Programming Language :: Python :: 3.6
 test_suite = requests_unixsocket.tests
 
 [files]
@@ -28,3 +27,8 @@
 
 [wheel]
 universal = 1
+
+[egg_info]
+tag_build = 
+tag_date = 0
+

$ cat old/sdist/requests-unixsocket-0.3.0/ChangeLog
CHANGES
=======

0.3.0
-----

* Remove urllib3 dep
* Update setup.cfg metadata - => \_
* Remove Vagrantfile
* Remove .travis.yml
* Update tox to work
* README.rst: Update badge from Travis => GH
* Fix warning from waitress
* Add GitHub Actions tests
* Remove --pep8 option to pytest
* Bump waitress from 1.4.2 to 1.4.3
* Bump py from 1.4.32 to 1.10.0
* Bump waitress from 0.9.0 to 1.4.2
* Allow UnixAdapter to accept max\_retries parameter

0.2.0
-----

* .travis.yml: Switch to only matrix.include
* .travis.yml: Add Python 3.7
* tox.ini: Test py37
* examples/docker-info.py: Make executable (#33)
* Add examples/simple-http.py (#32)
* Add Makefile (#31)
* Move examples to separate directory
* README.rst: Give up on linking to file
* README.rst: Fix links
* Example for abstract namespace sockets
* Vagrantfile: Add socat
* Vagrantfile: xenial64 and install all Pythons
* .gitignore: Add .vagrant
* Vagrantfile: Remove unnecessary comments
* README.rst: Fix HTTPie link
* README.rst: See also: httpie-unixsocket
* README.rst: Make examples use docker.sock
* Add Vagrantfile
* Add sample.py
* test-requirements.txt: Get rid of pytest warnings
* tox.ini: Add py26 back
* test-requirements.txt: Remove redundancy
* .travis.yml: Remove py36
* Revert ".travis.yml: Try another way"
* .travis.yml: Try another way
* Pin test-requirements
* .travis.yml: Add sudo: false
* Add support for Python 3.6
* Remove support for Python 2.6
* Close socket on deletion
* Non case sensitive url comparison in tests
* Pull in more recent code from docker-py
* Fix PyPI badge
* Override HTTPAdapter.request\_url

0.1.5
-----

* Fix test\_unix\_domain\_adapter\_connection\_proxies\_error
* .travis.yml tweaks
* Remove py32; Add py35
* Only reject proxies if they are relevant (which should be never)
* Add urllib3 requirement
* Add basic tests for all supported methods
* More PEP8 compliance refactoring
* Fix up some oversights in method parsing
* Tweak a few things in PR 12
* Make PEP8 compliant with autopep8
* Improve the monkey-patching library to replicate requests more closely

0.1.4
-----

* README.rst: Add PyPI badge
* Monkeypatch requests.request

0.1.3
-----

* Fix #6 ("GET parameters stripped from URL")
* GH-7: Fallback to import from urllib3

0.1.2
-----

* Tweak monkeypatch code
* Move/expose testutils like UnixSocketServerThread
* Make monkeypatch url\_scheme arg optional

0.1.1
-----

* Remove :class: role from README.rst

0.1.0
-----

* Doc tweaks
* Expose Session and monkeypatch
* Add Travis CI build badge
* Test Python 3.2 with tox and Travis CI
* Use threading.Event to less chance of race cond
* Add .travis.yml for Travis CI
* Change process => thread for test UnixSocketServer
* Make WSGIApp use server attribute for shutdown
* Use WSGIApp callable instead of closure
* In tests, try to gracefully kill waitress server
* Display text coverage report in tox coverage env
* Add test for proxies error
* Use b literal in test; fix py3 test failures
* tox.ini: Correct name of env pep8 => flake8
* tox.ini: Rename pep8 => flake8
* .gitignore: Add AUTHORS and ChangeLog
* Add pytest-pep8
* Improve tests
* Yay, tests are passing
* .gitignore: Add .eggs/ for setuptools==7.0
* Rename README.md -> README.rst
* Initial commit

$ cat old/sdist/requests-unixsocket-0.3.0/AUTHORS  
Aaron Gallagher <[email protected]>
Ben Jackson <[email protected]>
David Preece <[email protected]>
Esben Haabendal <[email protected]>
Marc Abramowitz <[email protected]>
Marc Abramowitz <[email protected]>
Marc Abramowitz <[email protected]>
Ondřej Kobližel <[email protected]>
Tomaz Solc <[email protected]>
Will Rouesnel <[email protected]>
William Rouesnel <[email protected]>
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

It's unclear if the changes to setup.cfg were local or pbr made them too. I'm not going to attempt digging deeper and will create a tag on this commit assuming that it's the source.

@webknjaz webknjaz closed this as completed Feb 6, 2025
@webknjaz
Copy link
Collaborator

webknjaz commented Feb 6, 2025

@sshedi
Copy link
Author

sshedi commented Feb 6, 2025

AFAIK, there should be a one to one mapping between the tarball given by pypi and git tag.
These things are a tough pill to swallow while created SBOM of sources and can lead to tough situations in security audits.

@webknjaz
Copy link
Collaborator

webknjaz commented Feb 6, 2025

Almost 1:1. With quirks. Also, not everyone agrees. But that's not in the scope of the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants