Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap across/down plugin corrupts puzzle grid #33

Open
jpd236 opened this issue Oct 22, 2016 · 1 comment
Open

Swap across/down plugin corrupts puzzle grid #33

jpd236 opened this issue Oct 22, 2016 · 1 comment

Comments

@jpd236
Copy link
Contributor

jpd236 commented Oct 22, 2016

The swap across/down plugin seems to be broken, at least on Mac.

One issue is that it calls a "SwapDirection" function which appears to have been renamed to "InvertDirection" in cb8e5c8.

However, even with that resolved, the grid ends up in a broken state after the swap. Grid numbers shift around as you click through the grid; the selected square doesn't always get highlighted; filled in answers can disappear.

(Given that this plugin folder begins with a "_", it seems like it might have been shelved and thus bitrotted... but I don't see anything at first glance that actually strips out such plugins from release builds. Will file a separate bug for that).

@mrichards42
Copy link
Owner

Yeah, it's definitely old and broken. I think this was written when the puz library was a lot simpler. I'm sure it would be possible to make it work again, but the novelty wore off pretty quickly, and I didn't bother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants