NURBSCurve.toJSON doesn't serialize points data

[canxerian]

Description

The JSON object returned from NURBSCurve.toJSON() doesn't contain data relating points, knots or control points, but instead contains:

{
    "metadata": {
        "version": 4.6,
        "type": "Curve",
        "generator": "Curve.toJSON"
    },
    "arcLengthDivisions": 200,
    "type": "Curve"
}

Reproduction steps

1. Create an instance of NURBSCurve (sample code below),
2. console.log nurbsCurveInstance.toJSON()
3. Notice there is no data relating to the instance, e.g points, knots and control points)

Code

const nurbsControlPoints = [];
const nurbsKnots = [];
const nurbsDegree = 3;

for (let i = 0; i <= nurbsDegree; i++) {
  nurbsKnots.push(0);
}

for (let i = 0, j = 20; i < j; i++) {
  nurbsControlPoints.push(
    new THREE.Vector4(
      Math.random(),
      Math.random(),
      Math.random(),
      1 // weight of control point: higher means stronger attraction
    )
  );

  const knot = (i + 1) / (j - nurbsDegree);
  nurbsKnots.push(THREE.MathUtils.clamp(knot, 0, 1));
}

const nurbsCurve = new NURBSCurve(nurbsDegree, nurbsKnots, nurbsControlPoints);

console.log(nurbsCurve.toJSON());

Live example

https://codesandbox.io/p/sandbox/threejs-nurbscurve-tojson-bug-s298gc

Screenshots

No response

Version

168

Device

Desktop, Mobile

Browser

Chrome, Firefox, Safari, Edge

OS

MacOS

[Mugen87]

NURBSCurve is part of the addons and there is no JSON support for this class right now. Only curves classes in the core support that.

Even with a proper NURBSCurve.toJSON() implementation you also need the fromJSON() counterpart to make a deserialization work.

[Mugen87]

The next problem is that objects deserialized with ObjectLoader can't restore instances of NURBSCurve because the type is unknown for the core. So we can only add partial serialization/deserialization support right now.

[canxerian]

Thanks for the quick reply, Mugen87.

I'm happy to add the functionality for NURBSCurve.toJSON and NURBSCurve.fromJSON, and can push a PR shortly.

With regard to ObjectLoader, if I understand correctly it appears that there's doesn't exist any support for any type of Curve yet.

[Mugen87]

ObjectLoader can save and load e.g. instances of ShapeGeometry which define their outlines via curves. The deserialization is delegated to CurvePath. The problematic bit is this:

three.js/src/extras/core/CurvePath.js

Line 244 in be667f1

this.curves.push( new Curves[ curve.type ]().fromJSON( curve ) );

Curves represents what is defined in this file: https://github.com/mrdoob/three.js/blob/be667f12f9f114ab3a4e12bbd45b99f9822ef56f/src/extras/curves/Curves.js

[canxerian]

Quick q @Mugen87, I came across the doc, https://github.com/mrdoob/three.js/wiki/Mr.doob%27s-Code-Style%E2%84%A2, but didn't see any mention of a VS Code formatter extension. Is there one available to auto format code for the preferred code style?

[Mugen87]

If you configure VS code with an ESLint extension, it should automatically detect the lint configuration in https://github.com/mrdoob/three.js/blob/dev/.eslintrc.json.