Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow user to specify username instead of error "Hg: no username supplied" #89

Open
hdpoliveira opened this issue Jun 21, 2020 · 3 comments

Comments

@hdpoliveira
Copy link
Collaborator

When doing the first commit, if the username is not specified, we issue an error:

image

We could prompt the user to enter a username instead.

@hdpoliveira
Copy link
Collaborator Author

Mercurial shows this:

hg commit hello -m Add hello
abort: no username supplied
(use 'hg config --edit' to set your username)

We can at least display a button to hg config --edit

@hdpoliveira hdpoliveira changed the title Allow user to specify username instead of error "Hg: no username supplied" Enhancement: Allow user to specify username instead of error "Hg: no username supplied" Jun 21, 2020
@incidentist
Copy link
Collaborator

I dig it. There's a function errorPromptOpenLog in interaction.ts that we'll want to use for this. It corresponds to the error-handling section of createCommand in the Git extension. I am refactoring it a little for #18, so let me finish that before you start this (assuming you want to take it, of course).

@hdpoliveira
Copy link
Collaborator Author

Ok! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants