From 29a01f257c80dfadd4a0024a50e81020d680345c Mon Sep 17 00:00:00 2001
From: Karan Sharma <hello@mrkaran.dev>
Date: Fri, 27 Nov 2020 18:22:56 +0530
Subject: [PATCH] feat: Dont set defaults for resource limits

Setting a default value isn't ideal. Causes unsuspecting OOM, high latencies due to CPU throttling etc.
---
 templates/containers.tmpl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/templates/containers.tmpl b/templates/containers.tmpl
index 22d1b48..c82a1fe 100644
--- a/templates/containers.tmpl
+++ b/templates/containers.tmpl
@@ -17,11 +17,11 @@
         {{- end}}
         resources:
           requests:
-            memory: {{- if .RequestsMemory }} {{.RequestsMemory}} {{- else }} 128Mi {{- end}}
-            cpu: {{- if .RequestsCPU }} {{.RequestsCPU}} {{- else }} 250m {{- end}}
+            memory: {{- if .RequestsMemory }} {{.RequestsMemory}}
+            cpu: {{- if .RequestsCPU }} {{.RequestsCPU}}
           limits:
-            memory: {{- if .LimitsMemory }} {{.LimitsMemory}} {{- else }} 256Mi {{- end}}
-            cpu: {{- if .LimitsCPU }} {{.LimitsCPU}} {{- else }} 500m {{- end}}
+            memory: {{- if .LimitsMemory }} {{.LimitsMemory}}
+            cpu: {{- if .LimitsCPU }} {{.LimitsCPU}}
         {{- if .ReadinessProbePort}}
         readinessProbe:
           httpGet: