#158: Added fields formatted_phone and phone to the To & From Models #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the To & From models
|
Test Please |
|
@mozts2005 Do you just mean write an integration test for it? |
|
Yes, I would Like to see some level of automated testing |
|
@mozts2005 So, this one is a little interesting. For an integration test, I'd have to add a way to create voice tickets through this wrapper. It would be a great feature enhancement, but, it (IMO) is out of scope for the ticket. I can create a unit test to ensure that the JSON outputted by the classes (To & From) are as expected and vice versa (properties are populated via JSON). Would this be acceptable? |
|
Unit test would be just. |
|
@mozts2005 Tests added. Let me know if you would like something different. |
mozts2005
added a commit
that referenced
this pull request
Nov 10, 2015
#158: Added fields formatted_phone and phone to the To & From Models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #158