Get Multiple Users, Side-Loading and Int-Long fixes. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement MergeUser/Async Implement GetMultipleUsers/Async Implement Side-Loading for GetAllUsers and GetMulipleUsers Change SearchResult.Id from int to long Change UserIdentity.UserId from int to long Implemented UpdateUserIdentity, but in documentation it uses the same endpoint as AddUserIdentity Unit Tests.
| var resultUser2 = api.Users.CreateUser(user2); | ||
|
|
||
| var mergedUser = api.Users.MergeUser(resultUser1.User.Id.Value, resultUser2.User.Id.Value); | ||
| Thread.Sleep(2000); |
There was a problem hiding this comment.
Please change to be an async test and remove the thread.Sleep
This will make it more stable
http://simoneb.github.io/blog/2013/01/19/async-support-in-nunit/
There was a problem hiding this comment.
Done and committed/pushed.
This was referenced Oct 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MergeUser/Async
Implement GetMultipleUsers/Async
Implement Side-Loading for GetAllUsers and GetMulipleUsers
Change SearchResult.Id from int to long
Change UserIdentity.UserId from int to long
Implemented UpdateUserIdentity, but in documentation it uses the same endpoint as AddUserIdentity
Unit Tests.