From 338d75f9cb8c8a5311de295aa27da558df750a0b Mon Sep 17 00:00:00 2001
From: Luca Greco <lgreco@mozilla.com>
Date: Thu, 11 Apr 2024 16:56:37 +0200
Subject: [PATCH] chore: chromedriver and geckodriver dependencies along with
 circleci config (#584)

* chore(circleci): updated browser-tools orb to 1.4.8 and cimg/node to 20.12

* chore(deps-dev): bump chromedriver from 112.0.0 to 123.0.3

* chore(deps-dev): bump geckodriver from 3.2.0 to 4.3.3

* test: Update unit test to match new expected behaviors with changes applied from PR #582

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---
 .circleci/config.yml        | 9 ++++-----
 package.json                | 4 ++--
 test/test-browser-global.js | 2 +-
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index e237edd9..ca067b7f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -9,14 +9,13 @@
 #
 # - to try run jobs locally:
 #
-#     circleci config process .circleci/config.yml > tmp/processed.yml
-#     circleci local execute -c tmp/processed.yml --job build-nodejs-current
+#     circleci local execute -c .circleci/config.yml build-nodejs-current
 #
 version: 2.1
 
 orbs:
   codecov: codecov/codecov@3.2.3
-  browser-tools: circleci/browser-tools@1.4.1
+  browser-tools: circleci/browser-tools@1.4.8
 
 references:
   working_directory: &working_directory ~/webextension-polyfill
@@ -26,14 +25,14 @@ references:
     # See https://hub.docker.com/r/cimg/node/tags for the cimg/node tags
     # related to specific nodejs versions.
     docker:
-      - image: cimg/node:14.19
+      - image: cimg/node:20.12
 
   defaults-browsers: &defaults-browsers
     <<: *defaults
     # Image variant (combined with circleci/browser-tools orb) used to
     # run integration tests using Firefox, Chrome and Xvfb.
     docker:
-      - image: cimg/node:14.19-browsers
+      - image: cimg/node:20.12-browsers
 
 
 commands:
diff --git a/package.json b/package.json
index 8a28a33b..e2e81204 100644
--- a/package.json
+++ b/package.json
@@ -24,11 +24,11 @@
     "babel-preset-minify": "0.5.2",
     "browserify": "17.0.0",
     "chai": "4.3.6",
-    "chromedriver": "112.0.0",
+    "chromedriver": "123.0.3",
     "cross-env": "7.0.3",
     "eslint": "8.35.0",
     "finalhandler": "1.2.0",
-    "geckodriver": "3.2.0",
+    "geckodriver": "4.3.3",
     "global-replaceify": "1.0.0",
     "grunt": "1.6.1",
     "grunt-babel": "8.0.0",
diff --git a/test/test-browser-global.js b/test/test-browser-global.js
index fcadbc05..66e388ed 100644
--- a/test/test-browser-global.js
+++ b/test/test-browser-global.js
@@ -28,7 +28,7 @@ describe("browser-polyfill", () => {
       runtime: {lastError: null},
     };
     const fakeBrowser = {
-      mycustomns: {mybrowserkey: true},
+      runtime: {id: "fakeid"},
     };
 
     return setupTestDOMWindow(fakeChrome, fakeBrowser).then(window => {