Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore common artifacts when zipping a directory #85

Closed
kumar303 opened this issue Mar 1, 2016 · 2 comments
Closed

Ignore common artifacts when zipping a directory #85

kumar303 opened this issue Mar 1, 2016 · 2 comments
Assignees
@kumar303

Comments

@kumar303
Copy link
Contributor

kumar303 commented Mar 1, 2016

The build command (#4) currently zips up the entire directory. It should ignore things like .git and other artifact. This is how jpm does it: https://github.com/mozilla-jetpack/jpm/blob/master/lib/ignore.js#L23
@kumar303 kumar303 self-assigned this Mar 9, 2016
@kumar303
Copy link
Contributor Author

kumar303 commented Mar 9, 2016

It should also not include copies of itself -- this currently happens because the local build directory gets included.

@kumar303 kumar303 mentioned this issue Mar 9, 2016
Merged
@kumar303 kumar303 mentioned this issue Mar 9, 2016
Closed
@kumar303
Copy link
Contributor Author

kumar303 commented May 4, 2016

This is documented https://developer.mozilla.org/en-US/Add-ons/WebExtensions/web-ext_command_reference#web-ext_build

@sjakthol sjakthol mentioned this issue May 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumar303 kumar303

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumar303