Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all command option values in config files #814

Closed
kumar303 opened this issue Feb 21, 2017 · 3 comments
Closed

Validate all command option values in config files #814

kumar303 opened this issue Feb 21, 2017 · 3 comments
Assignees

Comments

@kumar303
Copy link
Contributor

This is a stepping stone towards #176

If the developer runs a command like:

web-ext build

but their config file has an invalid option for an unrelated command, like:

{
  sign: {
    apiSekret: 'this-config-key-has-a-typo', 
  },
}

then it should still raise an 'invalid config option' error even though the developer did not execute the sign command.

@shubheksha
Copy link
Contributor

This should be taken care of in #842

@saintsebastian
Copy link
Contributor

@kumar303 i think this issue is solved as @shubheksha has mentioned

@kumar303
Copy link
Contributor Author

Ah, indeed it is. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants