Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unnecessary directories when linting #397

Closed
kumar303 opened this issue Jul 29, 2016 · 2 comments
Closed

Ignore unnecessary directories when linting #397

kumar303 opened this issue Jul 29, 2016 · 2 comments
Assignees

Comments

@kumar303
Copy link
Contributor

kumar303 commented Jul 29, 2016

When running web-ext lint in a source directory, the linter should ignore the artifacts directory and node_modules directory. Otherwise, it may begin parsing too many files which could lead to errors or unwanted linting results. Maybe there are other non-source directories we should ignore. We can probably re-use the filter rules from FileFilter.

See #396

@kumar303 kumar303 changed the title Ignore the artifacts directory when linting the source directory Ignore the unnecessary directories when linting the source directory Jul 29, 2016
@kumar303 kumar303 changed the title Ignore the unnecessary directories when linting the source directory Ignore unnecessary directories when linting the source directory Jul 29, 2016
@kumar303 kumar303 changed the title Ignore unnecessary directories when linting the source directory Ignore unnecessary directories when linting Jul 29, 2016
@pdehaan
Copy link
Contributor

pdehaan commented Jul 29, 2016

Is there a way to specify what file(s) get added/excluded from the web extension using web-ext (similar to the .jpmignore file)?
Or is that basically the same issue/request as #176?

We have mozilla/blok#69 to audit the files in our generated ZIP/XPI, but I wasn't sure how to exclude things like our /docs/, /web-ext-artifacts/, /tests/, and /coverage/ folders which aren't needed in our web extension.

@kumar303
Copy link
Contributor Author

We only have default ignore rules in place right now, which includes *.xpi and node_modules. It only applies to the build command currently. We should probably add options to the build command to customize it or, yes, a standard ignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants