-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken loading with existing Firefox profile (race condition) #1363
Comments
@icl7126 Let me ask some additional questions to get a better picture of the issue and how to reproduce it:
|
is the extension installed from AMO the same one that is installed temporarily from web-ext run? is the extension installed by web-ext run built using some transpiling/bundling tools like webpack or babel? are there errors logged in Browser Console or in web-ext run --verbose that may suggest which may be the underlying issues?
Produced by this procedure: My add-on GroupSpeedDial in development mode opens Options page and New tab page - this is done when background script starts. This is how I know my add-on was reloaded. |
I've just noticed one more thing. This Firefox profile I use for development, has also two other add-ons installed. When I run the Firefox with this profile, it all works fine (it's totally clean profile with just these 3 add-ons installed, not being used for anything else). However when I run this profile with web-ext, all add-ons are wrongly loaded (you can see this in the video - they don't have "Internal UUID" in the about:debugging page). So not just the one I'm developing, but the others that are normally installed through AMO are not working. And when I try to debug them, I get this error log:
All of this used to work before, it's probably caused by new Firefox. I'm using now Firefox Developer edition 63.0b4 (64-bit). |
Thanks @icl7126 the additional details were very helpful. Based on some additional logs collected by executing web-ext run with the addition of -p "extensions.logging.enabled=true", it seems that the extension installed in the original profile are being installed but disabled, my guess is that Firefox doesn't like that the pre-existing extensions in the cloned profile have actually an absolute path which points to the original profile. While we investigate the underlying issue in a bit more detail, you should be able to workaround it by using the additional --keep-profile-changes option, which tells web-ext to use the profile without cloning it:
(currently, because of #932, when using --keep-profile-changes you have to pass the profile path instead of the profile name, but you will be able to use the profile name again once we merge #1149). |
Thank you for the workaround - I will make a manual backup now and use the "keep profile changes" switch. |
Hello again,
|
@icl7126 Could you describe in more detail how you created that profile, and if you are able to reproduce the problem with a new problem from scratch, explain the steps to create that profile? To rule out any changes from
|
Well the profile is now quite old (I'm add-on developer for more than 2 years now). All profiles I use are created using Firefox profile manager. But the profile was used only for development without saving any changes. I've executed it normally only several times to update add-ons or to install new ones. I'm gonna try to create a new one, because I can see these two new bugs are not present on my home PC with the same version of
|
@Rob--W Is there some connection between my main Firefox profile and my testing profile? They both use same instance of Firefox Developer Edition, but they are distinct profiles. |
Unless you explicitly select your main profile (via Sometimes bugs only occur once after a version update (potentially related to profile-specific caching startup state, which is reset on updates), so if you want to reproduce the bug, you can consider making a backup of your test profile directory (while preserving attributes, timestamps in particular) before running the test. |
@Rob--W Steps:
EDIT: EDIT 2: |
@icl7126 Are you using a localized (non-English) version of Firefox? If so, it may be related to #1498 and https://bugzilla.mozilla.org/show_bug.cgi?id=1524679 If not, can you also reproduce if you do not use the profile manager, but a path to the directory? In the Bugzilla bug I put down some very explicit reproduction steps (in multiple comments). |
@Rob--W
But it's still broken - the add-ons appears for a moment on a toolbar and then disappears. |
Is this a feature request or a bug?
BUG
What is the current behavior?
web-ext run --firefox=firefoxdeveloperedition --firefox-profile=Addons --start-url about:debugging
What happened? There is a very high chance that your add-on won't be loaded as Temporary extension (see the about:debugging page). The add-on is loaded from the source files, however the automatic reloading is broken and the background script won't reload on source files change.
This is some king of race condition because there is small chance it will be loaded correctly.
What is the expected or desired behavior?
The add-on should be loaded as Temporary Extension.
The same way as it works with clean profile (without '--firefox-profile' switch').
Version information (for bug reports)
web-ext --version
2.9.1
v10.1.0
5.6.0
2.9.1
The text was updated successfully, but these errors were encountered: