From a52e229ca67c645a7cb8a507981da214b0a7d31a Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 4 Sep 2020 12:03:27 +0200 Subject: [PATCH] Revert "Download, rather than opening, PDF attachments in Firefox (bug 1661259, PR 12286 follow-up)" This reverts commit 2a0de0b66b41c345cd357cbb828b3ca6f49fd395. I can no longer reproduce these issues locally, and if ad blockers are still interfering with this functionality we really ought to pursue a mozilla-central solution to the problem instead. (Also, I'm no longer getting an "Open with Firefox"-option in the "Open with"-dialog making the PDF attachments experience worse for all users.) --- web/pdf_attachment_viewer.js | 1 - 1 file changed, 1 deletion(-) diff --git a/web/pdf_attachment_viewer.js b/web/pdf_attachment_viewer.js index 079b083ca221f..6646830cd9485 100644 --- a/web/pdf_attachment_viewer.js +++ b/web/pdf_attachment_viewer.js @@ -172,7 +172,6 @@ class PDFAttachmentViewer extends BaseTreeViewer { const element = document.createElement("a"); if ( - (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) && PdfFileRegExp.test(filename) && !viewerCompatibilityParams.disableCreateObjectURL ) {