Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quad points for annotations #6811

Closed
timvandermeij opened this issue Dec 27, 2015 · 3 comments · Fixed by #12696
Closed

Support quad points for annotations #6811

timvandermeij opened this issue Dec 27, 2015 · 3 comments · Fixed by #12696

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Dec 27, 2015

The PDF reference states that Link and text markup annotations can specify quad points. https://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_reference_1-7.pdf#page=634&zoom=auto,-246,530 explains this principle. Right now we create one container per annotation, but when quad points are defined, we need to create multiple containers with rectangles defined by a group of eight quad points. Below are known files that will benefit from quad points support, which are files where an annotation takes up multiple lines (which is not too common, fortunately):

It is also possible that the annotation's rectangle is not valid at all when quad points are specified, in which case we need to use the (at least first eight) quad points to determine the rectangle for the container. Known files are:

@THausherr
Copy link
Contributor

@timvandermeij
Copy link
Contributor Author

Quad points are now supported in the core and the API, so this issue is only about the viewer support now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants