Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named action for search not working in addon version #3565

Closed
timvandermeij opened this issue Aug 12, 2013 · 3 comments
Closed

Named action for search not working in addon version #3565

timvandermeij opened this issue Aug 12, 2013 · 3 comments
Labels

Comments

@timvandermeij
Copy link
Contributor

http://www.informatik.uni-freiburg.de/~frank/ENG/beamer/example/Beamer-class-example1.pdf

Was caused during review at #3057 (comment). Now, in the addon, nothing happens when clicking the magnifying glass, only in the github.io version it's working. We should always use the Firefox find bar where possible, and otherwise the PDF.js find bar. We can use the method from https://github.com/mozilla/pdf.js/pull/2485/files#diff-0 for this purpose.

@yurydelendik Since you did the review for the named actions PR, what do you think about this?

@yurydelendik
Copy link
Contributor

I'm looking at that from Firefox product point of view: why would some web page is allowed to show/hide UI controls on the browsers? Security implication must be considered for this issue and #2485 pr. (In case of find functionally the browser has full control of its controls)

@Snuffleupagus

This comment has been minimized.

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Jun 4, 2021

Closing since in all these years this hasn't been brought up anymore and there are indeed security/usability requirements to consider for this. Finally, this now needs to be fixed upstream and not here anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants