From eb3c588bf21fd4df98bbbeccea856f09fabd257d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Wang?= <fwang@igalia.com>
Date: Tue, 14 Jan 2025 08:28:16 +0000
Subject: [PATCH] Bug 1941267 [wpt PR 50043] - Remove unrelated checks from
 trusted-types-svg-script-set-href.html, a=testonly

Automatic update from web-platform-tests
Remove unrelated checks from trusted-types-svg-script-set-href.html (#50043)

* Remove unrelated checks from trusted-types-svg-script-set-href.html

This test is intended to cover setting href [1] [2] but it also
currently verifies some (currently not specified) unrelated behavior
when setting the text of the script via innerHTML. A similar test exist
in block-text-node-insertion-into-svg-script-element.html, but for a
disconnected script. This PR just move the unrelated test to
trusted-types-svg-script.html instead.

[1] https://github.com/w3c/svgwg/pull/934
[2] https://github.com/whatwg/dom/pull/1268

--

wpt-commits: 696792b6aa714c2d7c54b986814bbdbbdecf1dd8
wpt-pr: 50043
---
 .../trusted-types-svg-script-set-href.html    | 19 +++----------------
 .../trusted-types-svg-script.html             | 15 +++++++++++++++
 2 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/testing/web-platform/tests/trusted-types/trusted-types-svg-script-set-href.html b/testing/web-platform/tests/trusted-types/trusted-types-svg-script-set-href.html
index d94b0fb95b45d..e437df360db5e 100644
--- a/testing/web-platform/tests/trusted-types/trusted-types-svg-script-set-href.html
+++ b/testing/web-platform/tests/trusted-types/trusted-types-svg-script-set-href.html
@@ -12,7 +12,7 @@
   <svg id="svg"><script id="script">"some script text";</script></svg>
   <script>
     const policy = trustedTypes.createPolicy("policy", {
-        createScript: x => x, createHTML: x => x, createScriptURL: x => x });
+      createScriptURL: script_url => script_url });
 
     promise_test(t => {
       const elem = document.createElementNS(NSURI_SVG, "script");
@@ -104,27 +104,14 @@
     // but now expect all assignments to succeed.
     promise_test(t => {
       trustedTypes.createPolicy("default", {
-        createScript: (x, _, sink) => {
-          assert_equals(sink, 'SVGScriptElement text');
-          return x;
-        },
-        createHTML: (x, _, sink) => {
-          assert_equals(sink, 'Element innerHTML');
-          return x;
-        },
-        createScriptURL: (x, _, sink) => {
+        createScriptURL: (script_url, _, sink) => {
           assert_equals(sink, 'SVGScriptElement href');
-          return x;
+          return script_url;
         }});
 
       return Promise.resolve();
     }, "Setup default policy");
 
-    promise_test(t => {
-      document.getElementById("script").innerHTML = "'modified via innerHTML';";
-      return Promise.resolve();
-    }, "Assign String to SVGScriptElement.innerHTML w/ default policy.");
-
     promise_test(t => {
       const elem = document.createElementNS(NSURI_SVG, "script");
       elem.href.baseVal = "about:blank";
diff --git a/testing/web-platform/tests/trusted-types/trusted-types-svg-script.html b/testing/web-platform/tests/trusted-types/trusted-types-svg-script.html
index 4d604f353c944..2fca03906ab3a 100644
--- a/testing/web-platform/tests/trusted-types/trusted-types-svg-script.html
+++ b/testing/web-platform/tests/trusted-types/trusted-types-svg-script.html
@@ -40,5 +40,20 @@
       document.getElementById("svg").appendChild(elem);
       return promise_spv();
     }, "Modify SVGScriptElement via DOM manipulation.");
+
+    promise_test(t => {
+      trustedTypes.createPolicy("default", {
+        createScript: (input, _, sink) => {
+          assert_equals(sink, 'SVGScriptElement text');
+          return input;
+        },
+        createHTML: (input, _, sink) => {
+          assert_equals(sink, 'Element innerHTML');
+          return input;
+        },
+      });
+      document.getElementById("script").innerHTML = "'modified via innerHTML';";
+      return Promise.resolve();
+    }, "Assign String to SVGScriptElement.innerHTML w/ default policy.");
   </script>
 </body>