Don't error when running hosted.html require in dist/ vs. src/ #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gideonthomas
suggested changes
Apr 21, 2017
| @@ -131,12 +133,15 @@ | |||
| } | |||
|
|
|||
| // Support loading from src/ or dist/ to make local dev easier | |||
| require(["bramble/client/main"], function(Bramble) { | |||
| if(window.location.pathname === "/dist/hosted.html") { | |||
There was a problem hiding this comment.
this won't work on staging/production because of S3 object prefixes.
You would probably need to regex this instead (or to be safer, have a meta tag in the html indicating that it is a hosted version and query that)
There was a problem hiding this comment.
OK, I'll rework.
Speaking of this, can you tell me how we do paths for staging/prod so I can also fix my URL scheme for cached URLS in #549?
There was a problem hiding this comment.
I believe it's <domain>/bramble/<staging|production>/dist/index.html
where <domain> is mozillathimblelivepreview.net and it's either staging or production in the path.
|
I have a better fix for this in #782. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People constantly complain about the requirejs error we have when we load in
dist/. This doesn't rely on require to fail before trying to load in dist. NOTE: this only affectshosted.html(so testing).