Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a warning for the service_worker property #5152

Closed
regseb opened this issue Jan 2, 2024 · 0 comments · Fixed by #5156
Closed

Return a warning for the service_worker property #5152

regseb opened this issue Jan 2, 2024 · 0 comments · Fixed by #5156
Assignees
Milestone

Comments

@regseb
Copy link
Contributor

regseb commented Jan 2, 2024

Describe the problem and steps to reproduce it:

{
  "manifest_version": 3,
  "name": "Test case",
  "version": "1.0.0",
  "background": {
    "service_worker": "background.js",
    "scripts": ["background.js"]
  }
}

What happened?

Validation Summary:

errors 1
notices 0
warnings 0

ERRORS:

Code Message Description File Line Column
MANIFEST_FIELD_UNSUPPORTED "/background/service_worker" is not supported. "/background/service_worker" is not supported. manifest.json

What did you expect to happen?

  • If the background property has a scripts and a service_worker: return no error (or only a warning) for the service_worker property.
  • If the background property has only a service_worker: continue to return an error for the service_worker property.

Anything else we should know?

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants