Generator function causing JS_SYNTAX_ERROR

[lidel]

Describe the problem and steps to reproduce it:

Attempted to validate an extension whose background .js had generator function:

content: (async function * () { 
// ...

How to reproduce

git clone https://github.com/mozilla/libdweb.git 
cd libdweb && git checkout fbff435b33542b02bc35c0bb8c27bc203e6d4e6e
cd demo/protocol && npx [email protected] lint

What happened?

Code              Message                       Description
JS_SYNTAX_ERROR   JavaScript syntax error       There is a JavaScript syntax error in your code; validation cannot continue on this file.

What did you expect to happen?

Firefox runs generators just fine. It guess function * should be accepted?
I may be missing some background on this, but MDN support table is green:

Anything else we should know?

Versions:

"web-ext": "2.7.0" with "addons-linter": "1.0.0"

Examples of use of generator functions in browser extensions:

• https://github.com/mozilla/libdweb/blob/fbff435b33542b02bc35c0bb8c27bc203e6d4e6e/demo/protocol/protocol.js#L6
• https://github.com/ipfs-shipyard/ipfs-companion/blob/08ef6f3866eb26e8340bb32249a8ccc8ca89c536/add-on/src/lib/ipfs-protocol-libdweb.js#L23

[lidel]

Hm.. I repeated the test wih latest version and the error is gone:

git clone https://github.com/mozilla/libdweb.git 
cd libdweb && git checkout fbff435b33542b02bc35c0bb8c27bc203e6d4e6e
cd demo/protocol && npx [email protected] .

Does it mean generators were added after 1.0.0 and web-ext just needs to be bumped to the latest version of addons-linter?

[EnTeQuAk]

Does it mean generators were added after 1.0.0 and web-ext just needs to be bumped to the latest version of addons-linter?

Correct. There were quite a few updates after 1.0.0 even that added support for many more recent JS features (e.g generators like you described, catch without an exception etc).

I'm closing this in favor of mozilla/web-ext#1326