Choosing Schema Registry Subject Name Strategy

[enamrik]

Problem:

There are different naming strategies out there for naming the subject of a schema as seen here.

The schema registry implementation in this library hardcodes the TopicNameStrategy strategy as seen below.

xk6-kafka/avro.go

Line 23 in 8cceb22

subject := topic + "-" + string(element)

In my current project, we use a different strategy RecordNameStrategy. This is because we have topics that can contain messages of different schemas.

Request:

Can we consider allowing the user to pass a method that builds the subject name? This way the user can implement which ever naming strategy they use.

[mostafa]

Hey @enamrik,

thanks for pointing it out. I am thinking about exporting the whole functionality to JS. Please upvote the issue. I'd also be happy to see and review contributions. I'm currently working on fixing a bug with SASL and TLS. See the project board for updates, as I added this issue to the todo list.

There are other issues you might be interested:

• Retrieve schema by a known ID or subject, without hard-coding it in the script #54
• Retrieve a specific version of the Schema from Schema Registery #53
• Should serdes functionality be exported to JS? #50

[enamrik]

Hi @mostafa, I gave it shot and tried adding support for subject name strategies: #88. I tried to keep the change footprint small but I do have some suggested refactorings if you're interested. Please let me know what you think.

I'm also exploring another need I have which is for the consumer to support the special offsets i.e. -1 = latest, -2 = earliest. I have the changes and test on a branch https://github.com/enamrik/xk6-kafka/blob/handle_special_offsets/consumer.go#L40. Wanted to get your thoughts on this first PR before attempting a PR on special offsets.

[mostafa]

@enamrik Awesome! Thanks for your contribution. 🙏
I'll try to review the PR as soon as I can and possibly merge it. Also, I'd be very happy to know more about your refactoring suggestions. Please check the tickets for known issues.

[enamrik]

@enamrik Awesome! Thanks for your contribution. 🙏 I'll try to review the PR as soon as I can and possibly merge it. Also, I'd be very happy to know more about your refactoring suggestions. Please check the tickets for known issues.

Yes, now that I've added the features I needed for work and I'm more familiar with the codebase, I'd love to help on issues. I'll take a look at those you mentioned.

[mostafa]

Thanks to @enamrik, the issue is addressed in #88.

@enamrik Feel free to re-open the issue if you have anything else to add.

[mostafa]

Released in v0.11.0.