Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_distinct() support (artist browsing in ncmpc) #50

Closed
David-Igou opened this issue Apr 9, 2015 · 6 comments
Closed

get_distinct() support (artist browsing in ncmpc) #50

David-Igou opened this issue Apr 9, 2015 · 6 comments
Assignees
Labels
C-bug Category: This is a bug
Milestone

Comments

@David-Igou
Copy link

Updated today (Mopidy 1.0.0-5, mopidy-spotify 1.3.0-1) and ncmpc no longer views lists artists via the respective tab. Searching and playlists work fine, but nothing is listed under artists.

@chigley
Copy link
Contributor

chigley commented Apr 17, 2015

+1. I've been a little slow to update, but am experiencing the same issue (mopidy-1.0.0-3, mopidy-spotify-1.3.0-0mopidy2).

@adamcik
Copy link
Member

adamcik commented Apr 17, 2015

See the following extract from the Mopidy 1.0 changelog:

Add support for blacklisting MPD commands. This is used to prevent clients from using listall and listallinfo which recursively lookup the entire “database”. If you insist on using a client that needs these commands change mpd/command_blacklist.

Likely ncmpc, like ncmpcpp uses these bad commands that we are somewhat strongly trying to push clients away from by blacklisting them by default. So please check your ncmpc version if there is a never one that doesn't use these commands any more.

@trygveaa
Copy link
Member

@adamcik: That is not the problem. ncmpc uses "list Artist", and this seems to return nothing from Spotify with Mopidy 1.0 and Mopidy-Spotify 1.3.

@adamcik
Copy link
Member

adamcik commented Apr 17, 2015

Ok, in that case it sounds like we might have messed up something with respect to get_distinct

@adamcik adamcik added this to the v1.3.1 milestone Apr 17, 2015
@adamcik adamcik added the C-bug Category: This is a bug label Apr 17, 2015
@adamcik
Copy link
Member

adamcik commented Apr 17, 2015

Right, like outright forgetting to implement it...

@jodal jodal removed this from the v1.3.1 milestone Jun 2, 2015
@jodal jodal added this to the v2.0 milestone Jun 17, 2015
@jodal jodal self-assigned this Jun 22, 2015
@jodal
Copy link
Member

jodal commented Jun 22, 2015

I have some work in progress for a get_distinct() implementation for Mopidy-Spotify 2.0 that seems to work really nicely. The library view in ncmpc/ncmpcpp is actually very usable with this :-)

@jodal jodal changed the title Browsing of artists get_distinct() support (artist browsing in ncmpc) Jun 23, 2015
@jodal jodal closed this as completed in 73b0160 Jul 16, 2015
@jodal jodal removed the 2 - Working label Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

5 participants