Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitrate setting is not saved when YUV 4:4:4 is enabled #1387

Closed
KWottrich opened this issue Aug 13, 2024 · 3 comments · Fixed by #1388
Closed

Bitrate setting is not saved when YUV 4:4:4 is enabled #1387

KWottrich opened this issue Aug 13, 2024 · 3 comments · Fixed by #1388

Comments

@KWottrich
Copy link

Describe the bug
When using a build of the client that has YUV 4:4:4 enabled, going into the settings and changing the Video bitrate setting doesn't do anything. Dragging the slider and then closing and reopening settings resets the slider right back to the default for the resolution/FPS. In my case, that's 65 Mbps for 1920x1200@120 FPS. Disabling YUV 4:4:4 makes this issue go away

Steps to reproduce
Build from the latest master branch, with the changes merged in #1282. Enable "Enable YUV 4:4:4 (Experimental)" under Advanced Settings. Attempt to adjust video bitrate.

Screenshots
image
image

Affected games
N/A

Other Moonlight clients
N/A

Moonlight settings (please complete the following information)

  • Enable YUV 4:4:4
  • Adjusting Resolution/FPS/Video bitrate

Gamepad-related issues (please complete if problem is gamepad-related)
N/A

Client PC details (please complete the following information)

  • OS: Windows 11 23H2 (Build 22631.3880)
  • Moonlight Version: da0244c
  • GPU: NVidia Laptop 3050 Ti

Server PC details (please complete the following information)

Moonlight Logs (please attach)
Moonlight-1723551292.log

Additional context
#1282

@ns6089
Copy link
Contributor

ns6089 commented Aug 13, 2024

I will have a look.

@ns6089
Copy link
Contributor

ns6089 commented Aug 13, 2024

The value is getting saved, but the slider is reset to default when the options page reopened.
Will open PR with a fix shortly.

@ns6089
Copy link
Contributor

ns6089 commented Aug 13, 2024

Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants