We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This commit: 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2
Breaks connecting with envars.
Basically Meteor sets the APP_ID envar to the value of what's in .meteor/.id (see https://github.com/meteor/meteor/blob/devel/tools/static-assets/server/boot.js#L38 and https://github.com/meteor/meteor/blob/devel/tools/runners/run-app.js#L201 ).
APP_ID
.meteor/.id
Since 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2 adds https://github.com/monti-apm/monti-apm-agent/blob/master/lib/environment_variables.js#L1-L9 it now can use that APP_ID as the kadira app id, which breaks connection to monti apm of course. I think it's a very bad idea to allow non-prefixed envars anyway.
The text was updated successfully, but these errors were encountered:
ahh that explains why it didn't work for me ;)
Sorry, something went wrong.
Thanks for finding the cause @sebakerckhof. It is fixed in version 2.32.2.
No branches or pull requests
This commit: 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2
Breaks connecting with envars.
Basically Meteor sets the
APP_ID
envar to the value of what's in.meteor/.id
(see https://github.com/meteor/meteor/blob/devel/tools/static-assets/server/boot.js#L38 and https://github.com/meteor/meteor/blob/devel/tools/runners/run-app.js#L201 ).Since 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2 adds https://github.com/monti-apm/monti-apm-agent/blob/master/lib/environment_variables.js#L1-L9 it now can use that
APP_ID
as the kadira app id, which breaks connection to monti apm of course. I think it's a very bad idea to allow non-prefixed envars anyway.The text was updated successfully, but these errors were encountered: