Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting with envars is broken #5

Closed
sebakerckhof opened this issue Jul 12, 2018 · 2 comments
Closed

Connecting with envars is broken #5

sebakerckhof opened this issue Jul 12, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@sebakerckhof
Copy link
Contributor

sebakerckhof commented Jul 12, 2018

This commit: 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2

Breaks connecting with envars.

Basically Meteor sets the APP_ID envar to the value of what's in .meteor/.id (see https://github.com/meteor/meteor/blob/devel/tools/static-assets/server/boot.js#L38 and https://github.com/meteor/meteor/blob/devel/tools/runners/run-app.js#L201 ).

Since 671980b#diff-fb7fc841fcf9873d846fbd8249e2e4e2 adds https://github.com/monti-apm/monti-apm-agent/blob/master/lib/environment_variables.js#L1-L9 it now can use that APP_ID as the kadira app id, which breaks connection to monti apm of course. I think it's a very bad idea to allow non-prefixed envars anyway.

@sebakerckhof sebakerckhof changed the title Doesn't work with envars Connecting with envars is broken Jul 12, 2018
@zodern zodern added the bug Something isn't working label Jul 12, 2018
@hexsprite
Copy link

ahh that explains why it didn't work for me ;)

@zodern
Copy link
Member

zodern commented Jul 13, 2018

Thanks for finding the cause @sebakerckhof. It is fixed in version 2.32.2.

@zodern zodern closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants