Stack overflow in redis-oplog handling

[jdgjsag67251]

Hi, we recently updated to v2.49.2 It works great, but we do get multiple messages in Sentry about a call stack overflow in Monti in combination with redis-oplog: packages/montiapm:agent/lib/hijack/redis_oplog.js in MongoIDMap.store.constructor.compareWith at line 26:32.

Stacktrace

RangeError: Maximum call stack size exceeded
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:23:50)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)
    at MongoIDMap.store.constructor.compareWith (packages/montiapm:agent/lib/hijack/redis_oplog.js:26:32)

From the code I deduce that rewriteReloadRequeryFuncs is maybe called on a store multiple times causing it to overwrite the compareWith method multiple times?

Or maybe it's our combination of redis-oplog and changestream-to-redis?

[zodern]

Thanks for reporting this. I found a number of issues with the compareWith instrumentation. It's fixed in v2.49.3.