fix: Enables creation of database event trigger with watch against database and not collection (#1968)

* feat: permit database watch against creation 

In order to accept database watch against creation, config_collection should be empty string (config_collection = "")

* Update internal/service/eventtrigger/resource_event_trigger.go

Co-authored-by: Oriol <[email protected]>

* adjust documentation of resource and data sources

* include acceptance test for database trigger over a database with no specific collection

* use acc.RandomName

* docs: remove redudant required/optional when is it specific to a type

* doc: phrasing adjustment for config_database

---------

Co-authored-by: Alex <[email protected]>
Co-authored-by: Oriol <[email protected]>

Author: 3 people

internal/service/eventtrigger/data_source_event_trigger_test.go

@@ -38,12 +38,12 @@ func TestAccEventTriggerDS_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { acc.PreCheck(t) },
 		ProtoV6ProviderFactories: acc.TestAccProviderV6Factories,
-		CheckDestroy:             testAccCheckMongoDBAtlasEventTriggerDestroy,
+		CheckDestroy:             checkDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccMongoDBAtlasDataSourceEventTriggerConfig(projectID, appID, `"INSERT", "UPDATE"`, &event),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckMongoDBAtlasEventTriggerExists(resourceName, &eventResp),
+					checkExists(resourceName, &eventResp),
 				),
 			},
 		},

internal/service/eventtrigger/data_source_event_triggers_test.go

@@ -44,7 +44,7 @@ func TestAccEventTriggerDSPlural_basic(t *testing.T) {
 			{
 				Config: testAccMongoDBAtlasEventTriggersDataSourceConfig(projectID, appID, `"INSERT", "UPDATE"`, &event),
 				Check: resource.ComposeTestCheckFunc(
-					testAccCheckMongoDBAtlasEventTriggerExists(resourceName, &eventResp),
+					checkExists(resourceName, &eventResp),
 				),
 			},
 		},

internal/service/eventtrigger/resource_event_trigger.go

@@ -240,8 +240,8 @@ func resourceMongoDBAtlasEventTriggersCreate(ctx context.Context, d *schema.Reso
 	sche, oksch := d.GetOk("config_schedule")
 
 	if typeTrigger == "DATABASE" {
-		if !okCots || !okD || !okC || !okSI {
-			return diag.FromErr(fmt.Errorf("`config_operation_types`, `config_database`,`config_collection`,`config_service_id` must be provided if type is DATABASE"))
+		if !okCots || !okD || !okSI {
+			return diag.FromErr(fmt.Errorf("`config_operation_types`, `config_database`,`config_service_id` must be provided if type is DATABASE"))
 		}
 	}
 	if typeTrigger == "AUTHENTICATION" {