feat: Cleans up before and after Test Suite so they don't interfere (#1695)

* don't schedule clean-up job as it'll be called from Test Suite

* run clean before and after

* secrets inherit

Author: lantoli

.github/workflows/cleanup-test-env.yml

@@ -1,9 +1,8 @@
 name: 'Cleanup test env'
 
 on:
-  workflow_dispatch: {} # workflow can be run manually
-  schedule:
-    - cron: "0 3 * * *" # workflow runs every day at 03:00 AM
+  workflow_dispatch: # workflow can be run manually
+  workflow_call: # workflow runs from Test Suite
 
 jobs:  
   cleanup-test-env-general:

.github/workflows/test-suite.yml

@@ -7,7 +7,13 @@ on:
 
 jobs:
 
+  clean-before:
+    secrets: inherit
+    uses: ./.github/workflows/cleanup-test-env.yml
+
   mig-tests:
+    needs: clean-before
+    if: ${{ !cancelled() }}
     strategy:
       max-parallel: 1
       fail-fast: false
@@ -23,7 +29,7 @@ jobs:
 
   acc-tests:
     needs: mig-tests
-    if: ${{ !cancelled() }} # run acc tests even if mig tests fail
+    if: ${{ !cancelled() }}
     strategy:
       max-parallel: 1
       fail-fast: false
@@ -34,3 +40,10 @@ jobs:
     uses: ./.github/workflows/acceptance-tests.yml
     with:
       terraform_version: ${{ matrix.terraform_version }}
+
+  clean-after:
+    needs: acc-tests
+    if: ${{ !cancelled() }}
+    secrets: inherit
+    uses: ./.github/workflows/cleanup-test-env.yml
+