fix(NODE-6523): deleteMany in gridfs passes timeoutMS to predicate, not options #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
commented
Nov 7, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Nov 7, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Show resolved
Hide resolved
nbbeeken
requested changes
Nov 7, 2024
nbbeeken
requested changes
Nov 8, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
requested changes
Nov 8, 2024
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Outdated
Show resolved
Hide resolved
…erations_timeout.prose.test.ts Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Pass
timeoutMSas an option, not a field in the filter predicate, to deleteMany() when aborting a gridfs upload stream.Also, I reworked the flaky CSOT test reported in https://jira.mongodb.org/browse/NODE-6522. I'm not sure what caused the flakiness, but now it every time on macos now (ex run of 1000 iterations: https://spruce.mongodb.com/version/672cfbacdc76ef0007d99ed6/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC).
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript