Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5444)!: emit deprecation warning for useNewUrlParser and useUnifiedTopology #3792

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 2, 2023

Description

What is changing?

  • emit deprecation warning for useNewUrlParser and useUnifiedTopology
  • unit test for warning
Is there new documentation needed for these changes?

Yes. Docs changes is filed on the ticket.

What is the motivation for this change?

See below

Release Highlight

useNewUrlParser and useUnifiedTopology emit deprecation warnings

These options were removed in 4.0.0 but continued to be parsed and silently left unused. We have now added a deprecation warning through Node.js' warning system to prepare for finally removing these options in the next major release.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review August 2, 2023 19:33
@durran durran self-assigned this Aug 3, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 3, 2023
src/connection_string.ts Outdated Show resolved Hide resolved
@alexbevi
Copy link
Contributor

alexbevi commented Aug 3, 2023

@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 3, 2023
@nbbeeken nbbeeken requested a review from baileympearson August 3, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants