-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-4796)!: remove addUser and collection.stats APIs #3781
Conversation
133db0d
to
4839da3
Compare
4839da3
to
cdfff2d
Compare
cdfff2d
to
512c965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't flag all of them, but can we update the tests that got touched to use async syntax? Other than that, lgtm.
@@ -102,7 +101,7 @@ describe('URI', function () { | |||
|
|||
c.close(() => client.close(done)); | |||
}); | |||
}); | |||
}, done); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason not to convert this test to use async syntax?
Description
What is changing?
Removing deprecations
mongodb-js/nodejs-mongodb-legacy#22
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
db.addUser()
andadmin.addUser()
removedThe deprecate
addUser
APIs have been removed. The driver maintains support across many server versions and thecreateUser
command has support for different features based on the server's version, since applications can generally write code to work against a uniform and perhaps more modern server the path forward is for applications to send the createUser command directly.The associated options interface with this API has also been removed:
AddUserOptions
.See
createUser
documentation: https://www.mongodb.com/docs/manual/reference/command/createUser/collection.stats()
removedThe collStats command is deprecated starting in server v6.2 so the driver is removing it's bespoke helper in this major release. The collStats command is still usable from manually running it via
await db.command()
. However, the recommended migration is to use the$collStats
aggregation stage. You can find more information here: $collStats.The associated interfaces with this API have also been removed:
CollStatsOptions
andWiredTigerData
.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript