Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5228)!: remove unneeded fields from ConnectionPoolCreatedEvent.options #3772

Merged
merged 6 commits into from
Jul 19, 2023
Merged

fix(NODE-5228)!: remove unneeded fields from ConnectionPoolCreatedEvent.options #3772

merged 6 commits into from
Jul 19, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jul 14, 2023 •
edited
Loading

Description

What is changing?

  • Remove unneeded fields from ConnectionPoolCraetedEvent.options
  • Made ConnectionPoolCreatedEvent.options field required
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Removed unneeded fields from ConnectionPoolCreatedEvent.options

The options field of ConnectionPoolCreatedEvent now has the following shape:

{
	maxPoolSize: number,
	minPoolSize: number,
	maxConnecting: number,
	maxIdleTimeMS: number,
	waitQueueTimeoutMS: number
}

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title fix(NODE-5228): fix ConnectionPoolCreatedEvent fix(NODE-5228)!: remove unneeded fields from ConnectionPoolCreatedEvent.options Jul 14, 2023
@W-A-James W-A-James marked this pull request as ready for review July 14, 2023 19:41
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 14, 2023
@nbbeeken nbbeeken self-assigned this Jul 14, 2023
@W-A-James W-A-James requested a review from nbbeeken July 14, 2023 21:41
nbbeeken
nbbeeken approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 17, 2023
@nbbeeken nbbeeken requested a review from baileympearson July 18, 2023 14:54
@dariakp
Copy link
Contributor

dariakp commented Jul 18, 2023 •
edited
Loading

Friendly reminder to not forget the release highlight @nbbeeken @W-A-James

@nbbeeken nbbeeken merged commit 7a91714 into main Jul 19, 2023
@nbbeeken nbbeeken deleted the NODE-5228 branch July 19, 2023 19:09
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@W-A-James @dariakp @nbbeeken @baileympearson