fix(NODE-3272)!: emit correct event type when SRV Polling #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested review from
a team,
durran,
emadum and
dariakp
and removed request for
a team
emadum
approved these changes
Jun 2, 2021
| @@ -246,12 +246,25 @@ class EventCollector { | |||
| } | |||
| } | |||
|
|
|||
| function getSymbolFrom(target, symbolName, assertExists = true) { | |||
There was a problem hiding this comment.
Thanks, and good catch on the other ticket I'll be sure to note it in the merge
dariakp
requested changes
Jun 2, 2021
test/unit/sdam/topology.test.js
Outdated
| new SrvPollingEvent([{ priority: 1, weight: 1, port: 2, name: 'fake' }]) | ||
| ); | ||
|
|
||
| // The srv event starts a monitor that we don't actually want running |
There was a problem hiding this comment.
let's move the cleanup into an afterEach and iterate over all servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the event type emitted from the SRV polling listener on the Topology.
Also:
Skipped the cursor tests and marked them with the unskip ticket, and corrected the visibility on session properties.