+
diff --git a/web-components/src/components/icon/Icon.ts b/web-components/src/components/icon/Icon.ts
index aa4c88b61..45611a9fa 100644
--- a/web-components/src/components/icon/Icon.ts
+++ b/web-components/src/components/icon/Icon.ts
@@ -174,7 +174,7 @@ export namespace Icon {
*/
@property({ type: String }) iconSet: IconSet = "momentumUI";
- private static designLookup = new Map(Object.entries(designMapping));
+ private static readonly designLookup = new Map(Object.entries(designMapping));
@internalProperty()
private svgIcon: HTMLElement | null = null;
@@ -450,7 +450,7 @@ export namespace Icon {
role="img"
aria-label=${this.ariaLabel}
title=${this.title}
- aria-hidden=${ifDefined(this.ariaHidden || undefined)}
+ aria-hidden=${ifDefined(this.ariaHidden ?? undefined)}
@click=${(event: MouseEvent) => this.handleIconClick(event)}
>
@@ -465,7 +465,7 @@ export namespace Icon {
role="img"
aria-label=${this.ariaLabel}
title=${this.title}
- aria-hidden=${ifDefined(this.ariaHidden || undefined)}
+ aria-hidden=${ifDefined(this.ariaHidden ?? undefined)}
@click=${(event: MouseEvent) => this.handleIconClick(event)}
>
${this.svgIcon ? this.svgIcon : nothing}
diff --git a/web-components/src/components/tabs/Tabs.ts b/web-components/src/components/tabs/Tabs.ts
index 5c71ad026..fbaf7eb79 100644
--- a/web-components/src/components/tabs/Tabs.ts
+++ b/web-components/src/components/tabs/Tabs.ts
@@ -55,7 +55,7 @@ export namespace Tabs {
@property({ type: Boolean, attribute: "draggable" }) draggable = false;
@property({ type: String }) direction: "horizontal" | "vertical" = "horizontal";
@property({ type: Number, attribute: "more-items-scroll-limit" }) moreItemsScrollLimit = Number.MAX_SAFE_INTEGER;
- @property({ type: Number, reflect: true, attribute: 'selected-index' }) selectedIndex = 0;
+ @property({ type: Number, reflect: true, attribute: "selected-index" }) selectedIndex = 0;
@property({ type: Number }) delay = 0;
@property({ type: Number }) animation = 100;
@property({ type: String, attribute: "ghost-class" }) ghostClass = "";
@@ -323,8 +323,8 @@ export namespace Tabs {
}
const comparator = (a: Tab.ELEMENT | TabPanel.ELEMENT, b: Tab.ELEMENT | TabPanel.ELEMENT) => {
- const aName = a.getAttribute("name") || "";
- const bName = b.getAttribute("name") || "";
+ const aName = a.getAttribute("name") ?? "";
+ const bName = b.getAttribute("name") ?? "";
return this.tabsOrderPrefsArray.indexOf(aName) - this.tabsOrderPrefsArray.indexOf(bName);
};
@@ -594,8 +594,7 @@ export namespace Tabs {
} else {
this.updateSelectedTab(selectedTabPanelIndex);
}
- this.noTabsVisible =
- this.tabsFilteredAsVisibleList.length === 0 && this.tabsFilteredAsHiddenList.length === 0 ? true : false;
+ this.noTabsVisible = this.tabsFilteredAsVisibleList.length === 0 && this.tabsFilteredAsHiddenList.length === 0;
this.requestUpdate();
}
@@ -609,9 +608,9 @@ export namespace Tabs {
if (tabs && panels) {
[oldSelectedIndex, newSelectedIndex].forEach((index) => {
const tab = tabs[index];
- tab && tab.toggleAttribute("selected");
+ tab?.toggleAttribute("selected");
const panel = panels[index];
- panel && panel.toggleAttribute("selected");
+ panel?.toggleAttribute("selected");
if (tab) {
const tabCopy = this.tabsCopyHash[this.getCopyTabId(tab)];
if (tabCopy) {
@@ -688,7 +687,7 @@ export namespace Tabs {
}
private getCurrentIndex(tabId: string) {
- const arrayLength = this.visibleTabsContainerElement?.children.length || 0;
+ const arrayLength = this.visibleTabsContainerElement?.children.length ?? 0;
for (let i = 0; i < arrayLength; i++) {
if (this.visibleTabsContainerElement?.children[i].id === tabId) {
return i;
@@ -700,7 +699,7 @@ export namespace Tabs {
private moveFocusToAdjacentTab(elementId: string, direction: "previous" | "next" | "fromMoreTabs") {
const currentTabIndex = this.getCurrentIndex(elementId);
const visibleTabs = this.visibleTabsContainerElement?.children;
- const visibleArrayLength = visibleTabs?.length || 0;
+ const visibleArrayLength = visibleTabs?.length ?? 0;
if (!visibleTabs || visibleArrayLength === 0) return;
diff --git a/web-components/src/components/theme/Theme.ts b/web-components/src/components/theme/Theme.ts
index ce5518eb3..7e7cf53b3 100644
--- a/web-components/src/components/theme/Theme.ts
+++ b/web-components/src/components/theme/Theme.ts
@@ -66,7 +66,7 @@ export namespace Theme {
private placement: Tooltip.Placement = "bottom";
private popperInstance: Instance | null = null;
- private eventListeners: {
+ private readonly eventListeners: {
mouseEnter?: (event: MouseEvent) => void;
mouseLeave?: (event: MouseEvent) => void;
} = {};
@@ -270,9 +270,12 @@ export namespace Theme {
options: {
offset: ({ placement }: { placement: Placement }) => {
const padding = halfArrowSize + additionalPadding;
- if (placement.startsWith("left") || placement.startsWith("right")) {
- return [0, padding];
- } else if (placement.startsWith("top") || placement.startsWith("bottom")) {
+ if (
+ placement.startsWith("left") ||
+ placement.startsWith("right") ||
+ placement.startsWith("top") ||
+ placement.startsWith("bottom")
+ ) {
return [0, padding];
}
return [8, 8]; // leave old defaults
diff --git a/web-components/src/wc_scss/themes/global--dark.scss b/web-components/src/wc_scss/themes/global--dark.scss
index 02327e6fe..1decfba70 100644
--- a/web-components/src/wc_scss/themes/global--dark.scss
+++ b/web-components/src/wc_scss/themes/global--dark.scss
@@ -8,6 +8,10 @@
--md-default-focus-outline-color: #{$md-blue-40};
+ --md-glass-bg-color: #{$black-60};
+ --md-glass-overlay-bg-color: #{$black-80};
+ --md-glass-overlay-inactive-bg-color: #{$black-40};
+
// New Backgrounds
--md-primary-bg-color: #{$md-gray-100};
--md-primary-one-bg-color: #{$md-gray-95};
diff --git a/web-components/src/wc_scss/themes/global--light.scss b/web-components/src/wc_scss/themes/global--light.scss
index 1dc36ecc7..5374ca3c0 100644
--- a/web-components/src/wc_scss/themes/global--light.scss
+++ b/web-components/src/wc_scss/themes/global--light.scss
@@ -8,6 +8,10 @@
--md-default-focus-outline-color: #{$md-blue-60};
+ --md-glass-bg-color: #{$white-60};
+ --md-glass-overlay-bg-color: #{$white-80};
+ --md-glass-overlay-inactive-bg-color: #{$white-40};
+
// New Backgrounds
--md-primary-bg-color: #{$md-white};
--md-primary-one-bg-color: #{$md-white};
diff --git a/web-components/src/wc_scss/themes/global--mdv2.scss b/web-components/src/wc_scss/themes/global--mdv2.scss
index ae20c9550..660f939e3 100644
--- a/web-components/src/wc_scss/themes/global--mdv2.scss
+++ b/web-components/src/wc_scss/themes/global--mdv2.scss
@@ -106,6 +106,9 @@ $inter-medium-font: "Inter Medium", $font-family-sans-serif;
--md-dynamic-layout-button-inverted-border-color: #{$mds-color-theme-inverted-outline-button-normal};
--md-header-separator-color: transparent;
+ --md-glass-bg-color: #{$mds-color-theme-background-glass-normal};
+ --md-glass-overlay-bg-color: #{$mds-color-theme-background-glass-overlay-normal};
+ --md-glass-overlay-inactive-bg-color: #{$mds-color-theme-background-glass-overlay-inactive};
/**
* Temporarily disable overriding token background colours for mdv2
diff --git a/web-components/webpack.config.ts b/web-components/webpack.config.ts
index 41a76d5e7..07a639e9c 100644
--- a/web-components/webpack.config.ts
+++ b/web-components/webpack.config.ts
@@ -147,7 +147,8 @@ export const commonDev = merge(common, {
{ from: `${pMomentum}/core/css/momentum-ui.min.css.map`, to: "css" },
{ from: `${pMomentum}/icons/css/momentum-ui-icons.min.css`, to: "css" },
{ from: `${pCss}/*.css`, to: "css/[name].[ext]" },
- { from: `${pStats}/**/*.json`, to: "stats/[name].[ext]" }
+ { from: `${pStats}/**/*.json`, to: "stats/[name].[ext]" },
+ { from: `node_modules/@momentum-design/brand-visuals/dist/backgrounds`, to: "images/brand-visuals/backgrounds" }
]
})
]