Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default min_thickness #307

Closed
aekiss opened this issue Sep 30, 2019 · 1 comment
Closed

default min_thickness #307

aekiss opened this issue Sep 30, 2019 · 1 comment

Comments

@aekiss
Copy link
Collaborator

aekiss commented Sep 30, 2019

We need to work out what to do for the default min_thickness - see #303 and COSIMA/access-om2#161

@russfiedler suggested

The only way that I can think of protecting the user is to demand that they supply a valid min_thickness. Have a negative default and abort if it is negative with messages explaining how to safely choose a sensible value and why.

The message should also explain that the default for b8ea1c1 and earlier was 1m, but that this may cause problems, as explained here: COSIMA/access-om2#161
@aekiss
Copy link
Collaborator Author

aekiss commented Dec 13, 2019

Closing this issue - I've merged the updated PR #309 into master.

@aekiss aekiss closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aekiss