From 132f941a365bfa60b456d21b4a5d301fb3af9695 Mon Sep 17 00:00:00 2001 From: Miguel de Barros Date: Fri, 27 Aug 2021 13:15:18 +0200 Subject: [PATCH 1/2] fix(mojaloop/#2436): sdk-sch-adapter inb-API responds incorrectly for 'Unknown uri' error scenario - Fix for Inbound API Middleware for createHeaderValidator function would continue validating even if the resource was invalid, thereby replacing the Interface OpenAPI Validation of the createRequestValidator Middleware. --- src/InboundServer/middlewares.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/InboundServer/middlewares.js b/src/InboundServer/middlewares.js index 80dca9fe8..b6a3eecb6 100644 --- a/src/InboundServer/middlewares.js +++ b/src/InboundServer/middlewares.js @@ -185,6 +185,7 @@ const createHeaderValidator = (logger) => async ( // Only validate requests for the requested resources if (!resources.includes(resource)) { await next(); + return; } // Always validate the accept header for a get request, or optionally if it has been From b5d7dea7c60846930d814fe7cc69c72e46e53c31 Mon Sep 17 00:00:00 2001 From: Miguel de Barros Date: Fri, 27 Aug 2021 13:17:29 +0200 Subject: [PATCH 2/2] made it slightly cleaner --- src/InboundServer/middlewares.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/InboundServer/middlewares.js b/src/InboundServer/middlewares.js index b6a3eecb6..36eb24e7d 100644 --- a/src/InboundServer/middlewares.js +++ b/src/InboundServer/middlewares.js @@ -184,8 +184,7 @@ const createHeaderValidator = (logger) => async ( // Only validate requests for the requested resources if (!resources.includes(resource)) { - await next(); - return; + return await next(); } // Always validate the accept header for a get request, or optionally if it has been