Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added two payee sdks and ttk as hub in func tests #413

Merged
merged 17 commits into from
Nov 8, 2022

Conversation

vijayg10
Copy link
Contributor

@vijayg10 vijayg10 commented Nov 4, 2022

No description provided.

@vijayg10 vijayg10 self-assigned this Nov 4, 2022
mdebarros and others added 5 commits November 4, 2022 13:53
…private-shared-lib to use v0.2

feat(mojaloop/2949): [sdk-scheme-adapter][private-shared-lib] Update private-shared-lib to use v0.2.0 of @mojaloop/platform-shared-lib - mojaloop/project#2949
- upgraded @mojaloop/platform-shared-lib-nodejs-kafka-client-lib & @mojaloop/platform-shared-lib-messaging-types-lib dependencies, and re-factored messaging/kafka consumers/producers to use the raw Producers/Consumers
- removed dependencies from ncurc since we can now upgrade them as normal
- created IRawMessageHeader alias as IRawIMessageHeaders to reduce the re-factoring required
@vijayg10 vijayg10 marked this pull request as ready for review November 8, 2022 14:55
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a single comment.

Let me know your thoughts.

modules/api-svc/src/InboundServer/middlewares.js Outdated Show resolved Hide resolved
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vijayg10 vijayg10 merged commit 42a9d4a into master Nov 8, 2022
@vijayg10 vijayg10 deleted the feat/add-ttk-as-hub-in-func-tests branch November 8, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants