refactor!: merge in mojaloop-connector differences #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
changed the title
mdebarros
requested changes
May 5, 2022
kleyow
changed the title
kleyow
changed the title
mdebarros
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the sheer amount of changes with pulling in
mojaloop-connectorcode, I'm making this a breaking change for a major version bump even if this might not potentially break any deployments.If using the sdk-scheme-adapter in place of the deprecated
mojaloop-connectormake sure env
ALLOW_TRANSFER_WITHOUT_QUOTEis false. Scenarios that usemojaloop-connectorabsolutely requires a previous quote before allowing a transfer to proceed.