Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extensionList to quote request/response #269

Merged
merged 4 commits into from
Mar 26, 2021
Merged

feat: add extensionList to quote request/response #269

merged 4 commits into from
Mar 26, 2021
+799 −491

Conversation

shashi165
Copy link
Contributor

@shashi165 shashi165 requested a review from bushjames March 25, 2021 20:03
@shashi165 shashi165 self-assigned this Mar 25, 2021
@shashi165 shashi165 mentioned this pull request Mar 25, 2021
Closed
18 tasks
eoln
eoln suggested changes Mar 26, 2021
View reviewed changes
src/package.json Outdated Show resolved Hide resolved
mdebarros
mdebarros previously approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Except for @eoln's comment which needs to be addressed.

@shashi165 shashi165 requested review from eoln and mdebarros March 26, 2021 09:24
mdebarros
mdebarros approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shashi165 shashi165 merged commit 9cbed66 into master Mar 26, 2021
@shashi165 shashi165 deleted the feature/ext-list-new branch March 26, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@eoln eoln eoln approved these changes

@bushjames bushjames Awaiting requested review from bushjames bushjames is a code owner

@vgenev vgenev Awaiting requested review from vgenev

@vijayg10 vijayg10 Awaiting requested review from vijayg10 vijayg10 is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

Assignees

@shashi165 shashi165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customize extensionList elements in PUT /quotes when using ml-simulator
3 participants
@shashi165 @eoln @mdebarros