diff --git a/package-lock.json b/package-lock.json index 73635188..109310f4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17,7 +17,7 @@ "@mojaloop/central-services-health": "15.0.2", "@mojaloop/central-services-logger": "11.5.4", "@mojaloop/central-services-metrics": "12.4.4", - "@mojaloop/central-services-shared": "18.16.2", + "@mojaloop/central-services-shared": "18.17.0", "@mojaloop/central-services-stream": "11.4.3", "@mojaloop/event-sdk": "14.1.3", "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1", @@ -1824,9 +1824,9 @@ } }, "node_modules/@mojaloop/central-services-shared": { - "version": "18.16.2", - "resolved": "https://registry.npmjs.org/@mojaloop/central-services-shared/-/central-services-shared-18.16.2.tgz", - "integrity": "sha512-AswilqhAUB/NuDZ/pR5JIcmNJwmkH6nrMVbCn9G6IJVd/M0oMYdMBQVkQynjN7KHXH+Bu9Uicb+ivd2UcsE+Iw==", + "version": "18.17.0", + "resolved": "https://registry.npmjs.org/@mojaloop/central-services-shared/-/central-services-shared-18.17.0.tgz", + "integrity": "sha512-dzBJSKSin+vQFHPeT1TBlcZSq1uXXiwFRtAc6d34KRxzZp7cyUNp1+FUjQw0QnTdF+02PXdFz4urLP4JUkymlA==", "dependencies": { "@hapi/catbox": "12.1.1", "@hapi/catbox-memory": "5.0.1", diff --git a/package.json b/package.json index 85fcbf21..31c73021 100644 --- a/package.json +++ b/package.json @@ -114,7 +114,7 @@ "@mojaloop/central-services-health": "15.0.2", "@mojaloop/central-services-logger": "11.5.4", "@mojaloop/central-services-metrics": "12.4.4", - "@mojaloop/central-services-shared": "18.16.2", + "@mojaloop/central-services-shared": "18.17.0", "@mojaloop/central-services-stream": "11.4.3", "@mojaloop/event-sdk": "14.1.3", "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1", diff --git a/src/model/fxQuotes.js b/src/model/fxQuotes.js index b5e8ec25..71f83c59 100644 --- a/src/model/fxQuotes.js +++ b/src/model/fxQuotes.js @@ -593,7 +593,7 @@ class FxQuotesModel { // persist the error await this.db.createFxQuoteError(txn, conversionRequestId, { - errorCode: Number(error.errorCode), + errorCode: Number(error.errorCode) || 2001, // Internal Server Error: https://github.com/mojaloop/central-services-error-handling/blob/master/src/errors.js#L29 errorDescription: error.errorDescription }) @@ -607,7 +607,7 @@ class FxQuotesModel { histTimer({ success: true, queryName: 'handleFxQuoteError' }) } catch (err) { histTimer({ success: false, queryName: 'handleFxQuoteError' }) - this.log.error('error in handleFxQuoteError', err) + this.log.child({ headers, conversionRequestId, error }).error('error in handleFxQuoteError', err) if (txn) { await txn.rollback().catch(() => {}) } diff --git a/test/unit/serverStart.test.js b/test/unit/serverStart.test.js index 5d86fda6..69d5b489 100644 --- a/test/unit/serverStart.test.js +++ b/test/unit/serverStart.test.js @@ -184,8 +184,8 @@ describe('Server Start', () => { delete headers.date const expectedResult = { errorInformation: { - errorCode: '3101', - errorDescription: 'Malformed syntax - Invalid date header' + errorCode: '3102', + errorDescription: 'Missing mandatory element - Missing required date header' } }