Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position event partitioning strategy enhancement to use AccountId #3498

Closed
14 of 22 tasks
PaulGregoryBaker opened this issue Aug 28, 2023 · 1 comment
Closed
14 of 22 tasks

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Aug 28, 2023

Goal:

As a <stakeholder|persona>

I want to

so that

Note
During the transfer characterisation performance workstream, it was noted that the kafka key's for position updates were not correctly aligning to the accounts that were being updated. This story is to rectify that, so that congestion in the position handler is removed.

(This code (Kafka.proceed) is stilling in central services shared. This should be removed and added to the central services.)

Acceptance Criteria:

  • Verify that position events are keyed based on the database position account Id and base on the use case
    • prepare will be the Payer DFSP position account Id
    • fulfil will be the Payee DFSP position account Id
    • Abort will be the Payer DFSP position account id
  • The following components will need to be updated
    • Position handler
    • Fulfil handler
    • Timeout handler
  • Integration tests should be added to validate the partitioning strategy. (i.e verify message keys are the account id for the appropriate use case)
  • Verify that any new queries that are added (e.g. timeout handler to get position account id's) should be cached.

Complexity: <High|Medium|Low> > A short comment to remind the reason for the rating

Uncertainty: <High|Medium|Low> > A short comment to remind the reason for the rating


Tasks:

  • Update prepare, fulfil and timeout handler
  • Verify any newly added queries are cached
  • Update unit tests
  • Update integration tests

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • TBD

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@PaulGregoryBaker
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants