GP tests are failing when test currencies are used

[vijayg10]

Summary:
If I use test currencies such as XXX, XTS in TTK environment values, the GP test collection fails.
I think account lookup service doesn't have these currencies in the enum of the swagger file. I am not sure about the other places in mojaloop services.

Severity:
Medium

Priority:
Medium

Expected Behavior
TTK GP should pass with test currencies

Steps to Reproduce

1. Deploy mojaloop 14.1.0 (13.1.1) version
2. Change the env variable in TTK 'currency' to 'XXX'
3. Change the env variable in TTK 'currency2' to 'XTS'
4. Run TTK GP

Specifications

• Component (if known): account-lookup-service (There may be other services where the test currencies are not listed)
• Version: 13.1.1
• Bug found/raised by: @vijayg10

Pull Requests

• feat(mojaloop/#2740): add test currencies to api transaction-requests-service#92
• feat(mojaloop/#2740): add testing currency codes and update codeowners account-lookup-service#450
• chore(mojaloop/#2740): add test currencies to api mojaloop-simulator#154

[mdebarros]

The migration-seeds would also need to be updated to include the test currencies --> https://github.com/mojaloop/account-lookup-service/blob/master/seeds/currency.js

[elnyry-sam-k]

Thanks Vijay.. Can confirm that ALS swagger doesn't have the test currencies listed in the swagger enum: https://github.com/mojaloop/account-lookup-service/blob/b2e8cf5ef7e4ebe72441f24045be5b0d890c764a/src/interface/api-swagger.yaml#L1061 , so this has to be updated as an immediate fix..

Long term - we also need to look at using api-snippets so that any changes made in one place to the API can be used in all the services..

[elnyry-sam-k]

Marking this as high-priority to be picked up next

[kleyow]

Updated the ALS on moja2 and ran GP.

Only tests that are failing are transaction-requests-service ones. I've updated the currencies here. https://github.com/mojaloop/transaction-requests-service and will close this once that is merged.

[elnyry-sam-k]

Thanks Kevin, good find..