Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /quotes for malformed ID error response is 1001 instead of 3xxx #1169

Closed
4 tasks done
amarmodus opened this issue Jan 13, 2020 · 1 comment
Closed
4 tasks done
Assignees
Milestone

Comments

@amarmodus
Copy link

amarmodus commented Jan 13, 2020

Summary:
GET /quotes for malformed ID error response is 1001 rather than 3002 or 3xxx.

Screenshot 2020-01-13 17 53 30

Tasks:

  • Validate the changes
  • Make sure test added to postman test collection

Severity:
Low

Priority:
Low

Expected Behavior
either 400 http code with proper error code (3002 ) or 202 with callback error code of 3002

Steps to Reproduce

curl --location --request GET 'http://dev1-quoting-service.mojaloop.live/quotes/000000' \
--header 'Accept: application/vnd.interoperability.quotes+json;version=1' \
--header 'Content-Type: application/vnd.interoperability.quotes+json;version=1.0' \
--header 'Date: Mon, 13 Jan 2020 15:13:48 GMT' \
--header 'FSPIOP-Source: payerfsp' \
--header 'FSPIOP-Destination: payeefsp'

with another ID

curl --location --request GET 'http://dev1-quoting-service.mojaloop.live/quotes/482f5eb4-67b6-####-9737-c77b0@$4706c' \
--header 'Accept: application/vnd.interoperability.quotes+json;version=1' \
--header 'Content-Type: application/vnd.interoperability.quotes+json;version=1.0' \
--header 'Date: Mon, 13 Jan 2020 15:13:48 GMT' \
--header 'FSPIOP-Source: payerfsp' \
--header 'FSPIOP-Destination: payeefsp'

Specifications

  • Component (if known): central-services
  • Version:v8.7.0
  • Platform: AWS
  • Subsystem:quoting service
  • Type of testing: functional
  • Bug found/raised by:@amarmodus

Notes:

  • Severity when opened:
  • Priority when opened:

Pull Requests

@amarmodus amarmodus added the bug label Jan 13, 2020
@oderayi oderayi self-assigned this Jan 15, 2020
@oderayi oderayi added this to the Sprint 8.8 milestone Jan 15, 2020
@oderayi oderayi closed this as completed Jan 16, 2020
@elnyry-sam-k elnyry-sam-k reopened this Jan 17, 2020
@amarmodus amarmodus self-assigned this Jan 17, 2020
@amarmodus
Copy link
Author

Screenshot 2020-01-20 11 20 48

Screenshot 2020-01-20 11 20 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants