feat!: fx and interscheme implementation #492

vijayg10 · 2024-08-29T09:25:44Z

Changes:

Currency Conversion (FX)
- There are no changes required in the ALS implementation related to FX
Interscheme
- Proxy cache implementation using redis
- Parameterize switch id

* fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * test: temporarily disable int test shutdown * fix: update parameters for sendRequest and update tests * chore: update deps, re-enable int test shutdown --------- Co-authored-by: Steven Oderayi <[email protected]>

* fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * feat(csi-16): refactoring - moved getPartiesByTypeAndID to a separate file * ci: fix docker build * feat(csi-263): implemented getPartiesByTypeAndID proxy changes (#485) * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): update npm test:... scripts * feat(csi-263): added networks to redis in d-c * feat(csi-263): added proxyCache logic for success PUT /parties * feat(csi-263): added proxyCache logic for error PUT /parties * feat(csi-263): updated proxyConfig format * feat(csi-263): added jest-unit.config.js * feat(csi-215): updated test-harness version to use fx * chore(snapshot): 15.4.0-snapshot.0 * chore(snapshot): 15.4.0-snapshot.1 * chore(snapshot): 15.4.0-snapshot.2 * chore(snapshot): 15.4.0-snapshot.3 * chore(snapshot): 15.4.0-snapshot.4 * chore(snapshot): 15.4.0-snapshot.5 * chore(snapshot): 15.4.0-snapshot.6 * chore(snapshot): 15.4.0-snapshot.7 * chore(snapshot): 15.4.0-snapshot.8 * chore(snapshot): 15.4.0-snapshot.9 * chore(snapshot): 15.4.0-snapshot.10 * chore(snapshot): 15.4.0-snapshot.11 * feat: make proxy routing optional & update health check (#486) * chore(csi-16): updated central-services-shared version * chore(snapshot): 15.4.0-snapshot.12 * chore(snapshot): 15.4.0-snapshot.13 * chore(snapshot): 15.4.0-snapshot.14 * chore(csi-16): inited proxies cache * chore(snapshot): 15.4.0-snapshot.15 * chore(snapshot): 15.4.0-snapshot.16 * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added --runInBand to unit tests * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.17 * feat(csi-16): proxyCacheTtlSec = 40 * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.18 * Update docker/account-lookup-service/default.json Co-authored-by: Steven Oderayi <[email protected]> * Update test/integration-config.json Co-authored-by: Steven Oderayi <[email protected]> --------- Co-authored-by: Steven Oderayi <[email protected]> * feat(csi-334): e2e als-proxy flow validation (#487) * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): update npm test:... scripts * feat(csi-263): added networks to redis in d-c * feat(csi-263): added proxyCache logic for success PUT /parties * feat(csi-263): added proxyCache logic for error PUT /parties * feat(csi-263): updated proxyConfig format * feat(csi-263): added jest-unit.config.js * feat(csi-215): updated test-harness version to use fx * chore(snapshot): 15.4.0-snapshot.0 * chore(snapshot): 15.4.0-snapshot.1 * chore(snapshot): 15.4.0-snapshot.2 * chore(snapshot): 15.4.0-snapshot.3 * chore(snapshot): 15.4.0-snapshot.4 * chore(snapshot): 15.4.0-snapshot.5 * chore(snapshot): 15.4.0-snapshot.6 * chore(snapshot): 15.4.0-snapshot.7 * chore(snapshot): 15.4.0-snapshot.8 * chore(snapshot): 15.4.0-snapshot.9 * chore(snapshot): 15.4.0-snapshot.10 * chore(snapshot): 15.4.0-snapshot.11 * feat: make proxy routing optional & update health check (#486) * chore(csi-16): updated central-services-shared version * chore(snapshot): 15.4.0-snapshot.12 * chore(snapshot): 15.4.0-snapshot.13 * chore(snapshot): 15.4.0-snapshot.14 * chore(csi-16): inited proxies cache * chore(snapshot): 15.4.0-snapshot.15 * chore(snapshot): 15.4.0-snapshot.16 * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added --runInBand to unit tests * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.17 * feat(csi-16): proxyCacheTtlSec = 40 * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.18 * Update docker/account-lookup-service/default.json Co-authored-by: Steven Oderayi <[email protected]> * Update test/integration-config.json Co-authored-by: Steven Oderayi <[email protected]> * feat(csi-334): added source to proxyCache for payee case * chore(snapshot): 15.4.0-snapshot.19 * feat(csi-334): added axios-retry * chore(snapshot): 15.4.0-snapshot.20 * fix(csi-321): fixed failed GP tests * chore(snapshot): 15.4.0-snapshot.21 * fix(csi-321): fixed case of sendCallback to requester * chore(snapshot): 15.4.0-snapshot.22 * fix(csi-321): added contextLogger * fix(csi-334): add proxyLib with redis-cluster * chore(snapshot): 15.4.0-snapshot.23 * fix(csi-334): add proxyLib with redis-cluster * chore(snapshot): 15.4.0-snapshot.24 * fix(csi-334): fixed config * chore(snapshot): 15.4.0-snapshot.25 * fix(csi-334): used new proxyLib --------- Co-authored-by: Steven Oderayi <[email protected]> * fix(csi-334): switched to redis standalone; improved logging; added int-test * fix(csi-334): improved logging * chore(snapshot): 15.4.0-snapshot.26 * fix(csi-418): fixed oracle update logic; added tests (#490) * fix(csi-418): fixed oracle update logic; added tests * chore(snapshot): 15.4.0-snapshot.27 * fix(csi-418): fixed oracle update logic; added tests * chore(snapshot): 15.4.0-snapshot.28 * feat: PROXY_MAP * chore(snapshot): 15.4.0-snapshot.29 * feat(mojaloop/#4000): timeout handler (#489) --------- Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Kalin Krustev <[email protected]>

docker/mock-proxy/src/config.ts

Dockerfile

* fix: config * chore(snapshot): 15.4.0-snapshot.35

sonarqubecloud · 2024-10-21T09:51:48Z

Quality Gate failed

Failed conditions
13.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

package.json

elnyry-sam-k · 2024-11-13T10:34:05Z

Thanks for the PR and initial review Shashi..

Some comments:

About "Mock proxy", can you please add some text / documentation to describe it and the usage? Also the version is 0.x
Time-out handler - please document or provide links if it exists elsewhere
https://github.com/mojaloop/inter-scheme-proxy-cache-lib still shows as EXPERIMENTAL and doesn't have an official release yet - needs to be addressed before we merge this to main
Are there sequence diagrams for the new changes somewhere? Please confirm

Thank you!

kalinkrustev · 2024-11-14T13:27:15Z

@geka-evk can you check the comments above about the proxy

geka-evk · 2024-12-09T10:26:30Z

Added "Mock proxy" README
Added ALS Timeout flow description
inter-scheme-proxy-cache-lib has version 2.3.0.
Added links to Discovery flow diagram and Proxy implementation details into README documentation

docs/Proxy/P2P.md

elnyry-sam-k

Thanks Eugen

elnyry-sam-k · 2024-12-10T17:39:58Z

Thanks @geka-evk , approved the PR but inter-scheme-proxy-cache-lib needs to have "releases" on github repos similar to other mojaloop repos, not just tags.

Co-authored-by: Sam <[email protected]>

sonarqubecloud · 2024-12-11T11:18:42Z

Quality Gate failed

Failed conditions
13.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

oderayi and others added 18 commits June 25, 2024 10:01

feat(csi-164): parameterize 'switch' id (#482)

659da7e

chore(snapshot): 15.4.0-snapshot.0

7a7eb74

chore(snapshot): 15.4.0-snapshot.1

44f2929

chore(snapshot): 15.4.0-snapshot.2

4fbc391

chore(snapshot): 15.4.0-snapshot.3

891b00c

chore(snapshot): 15.4.0-snapshot.4

65779d3

chore(snapshot): 15.4.0-snapshot.5

3c05abe

chore(snapshot): 15.4.0-snapshot.6

9cce256

chore(snapshot): 15.4.0-snapshot.7

e46759b

chore(snapshot): 15.4.0-snapshot.8

82b527f

chore(snapshot): 15.4.0-snapshot.9

6c46051

chore(snapshot): 15.4.0-snapshot.10

b077907

chore(snapshot): 15.4.0-snapshot.11

34fbcef

chore(snapshot): 15.4.0-snapshot.12

c6f7505

chore(csi-16): updated deps

141fee9

chore(snapshot): 15.4.0-snapshot.13

cdda232

vijayg10 requested review from mdebarros, elnyry-sam-k, kleyow, geka-evk, bushjames and oderayi as code owners August 29, 2024 09:25

github-advanced-security bot found potential problems Aug 29, 2024

View reviewed changes

docker/mock-proxy/src/config.ts Fixed Show fixed Hide fixed

kleyow changed the title ~~feat: fx and interscheme implementation~~ feat!: fx and interscheme implementation Sep 26, 2024

chore: deps

bcbbfee

github-advanced-security bot found potential problems Sep 30, 2024

View reviewed changes

Dockerfile Fixed Show resolved Hide resolved

kalinkrustev added 2 commits October 1, 2024 08:16

chore(snapshot): 15.4.0-snapshot.32

bcd6e81

chore(snapshot): 15.4.0-snapshot.33

3be84f6

kalinkrustev and others added 3 commits October 1, 2024 08:16

chore(snapshot): 15.4.0-snapshot.34

7af3474

fix: jws signing (#497)

6fbe919

* fix: config * chore(snapshot): 15.4.0-snapshot.35

fix: github-advanced-security alerts

e22c7d4

shashi165 previously approved these changes Nov 11, 2024

View reviewed changes

elnyry-sam-k reviewed Nov 13, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

chore: addressed PR comments

f73de31

geka-evk dismissed shashi165’s stale review via f73de31 December 5, 2024 08:57

chore: added audit:check to pre-commit

58ee52b

geka-evk added 2 commits December 9, 2024 11:18

chore: added docs/Proxy

fe6895b

chore: added Timeout flow docs

caad81a

geka-evk requested review from elnyry-sam-k and shashi165 December 10, 2024 13:38

elnyry-sam-k reviewed Dec 10, 2024

View reviewed changes

docs/Proxy/P2P.md Outdated Show resolved Hide resolved

elnyry-sam-k previously approved these changes Dec 10, 2024

View reviewed changes

Update docs/Proxy/P2P.md

acc449f

Co-authored-by: Sam <[email protected]>

geka-evk dismissed elnyry-sam-k’s stale review via acc449f December 11, 2024 10:32

chore: updated license

8a9f69a

elnyry-sam-k approved these changes Dec 11, 2024

View reviewed changes

geka-evk merged commit c44e5e0 into main Dec 11, 2024
15 of 16 checks passed

geka-evk deleted the feat/fx-impl branch December 11, 2024 11:31

elnyry-sam-k mentioned this pull request Jan 8, 2025

DA to discuss and review Inter-scheme designs and implementation mojaloop/design-authority-project#112

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: fx and interscheme implementation #492

feat!: fx and interscheme implementation #492

vijayg10 commented Aug 29, 2024 •

edited

Loading

sonarqubecloud bot commented Oct 21, 2024 •

edited

Loading

elnyry-sam-k commented Nov 13, 2024

kalinkrustev commented Nov 14, 2024

geka-evk commented Dec 9, 2024 •

edited

Loading

elnyry-sam-k left a comment

elnyry-sam-k commented Dec 10, 2024

sonarqubecloud bot commented Dec 11, 2024

feat!: fx and interscheme implementation #492

feat!: fx and interscheme implementation #492

Conversation

vijayg10 commented Aug 29, 2024 • edited Loading

sonarqubecloud bot commented Oct 21, 2024 • edited Loading

Quality Gate failed

elnyry-sam-k commented Nov 13, 2024

kalinkrustev commented Nov 14, 2024

geka-evk commented Dec 9, 2024 • edited Loading

elnyry-sam-k left a comment

Choose a reason for hiding this comment

elnyry-sam-k commented Dec 10, 2024

sonarqubecloud bot commented Dec 11, 2024

Quality Gate failed

vijayg10 commented Aug 29, 2024 •

edited

Loading

sonarqubecloud bot commented Oct 21, 2024 •

edited

Loading

geka-evk commented Dec 9, 2024 •

edited

Loading