From 007520acad04c01826b53a4fdb9b5e11090c781a Mon Sep 17 00:00:00 2001
From: Rust Saiargaliev <fly.amureki@gmail.com>
Date: Sun, 16 Oct 2022 23:06:27 +0200
Subject: [PATCH] Unify env var names

---
 .github/workflows/tests.yml |  2 +-
 postgis-tests.sh            | 10 +++++-----
 postgres-docker             |  4 ++--
 tests/conftest.py           | 12 ++++++------
 tox.ini                     |  3 ++-
 5 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 25dba8e4..9ad2af82 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -16,8 +16,8 @@ jobs:
         image: postgis/postgis
         env:
           POSTGRES_DB: postgres
-          POSTGRES_PASSWORD: postgres
           POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: postgres
         ports:
           - 5432:5432
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
diff --git a/postgis-tests.sh b/postgis-tests.sh
index a7ff5c68..8bd00711 100755
--- a/postgis-tests.sh
+++ b/postgis-tests.sh
@@ -11,7 +11,7 @@ set -euo pipefail
 ### so if you are already running PostgreSQL locally, instead of using this
 ### script, simply run:
 ###
-###     # TEST_DB=postgis PGUSER=postgres python -m pytest
+###     # TEST_DB=postgis POSTGRES_USER=postgres python -m pytest
 ###
 ### This script uses the `python` on the current `$PATH`, but can be overridden
 ### by setting the `PYTHON_CLI` environment variable.
@@ -48,9 +48,9 @@ PYTHON=${PYTHON_CLI:-python}
 DEPS="$PYTHON"
 
 # Arg defaults
-export PGPORT=${PGPORT:-5432}
-export PGUSER=${PGUSER:-postgres}
-export PGPASSWORD=${PGPASSWORD:-postgres}
+export POSTGRES_PORT=${POSTGRES_PORT:-5432}
+export POSTGRES_USER=${POSTGRES_USER:-postgres}
+export POSTGRES_PASSWORD=${POSTGRES_PASSWORD:-postgres}
 export TEST_DB=${TEST_DB:-postgis}
 
 # Argument parsing using "getopt"
@@ -110,7 +110,7 @@ for dep in $DEPS; do
 done
 
 # Run the postgres container with all extensions installed
-$PROJECT_ROOT/postgres-docker --port $PGPORT
+$PROJECT_ROOT/postgres-docker --port POSTGRES_PORT
 
 # Run the tests
 $PYTHON -m pytest
diff --git a/postgres-docker b/postgres-docker
index d503d5a0..8933fcc3 100755
--- a/postgres-docker
+++ b/postgres-docker
@@ -48,7 +48,7 @@ DEPS="$DOCKER"
 # Arg defaults
 KILL=false
 CONTAINER_NAME=model-bakery-postgres
-PORT=${PGPORT:-5432}
+PORT=${POSTGRES_PORT:-5432}
 
 # Argument parsing using "getopt"
 OPTIONS=h,k,p
@@ -66,7 +66,7 @@ eval set -- "$PARSED"
 while true; do
     case "$1" in
         -p|--port)
-            PGPORT=$2
+            POSTGRES_PORT=$2
             shift
             ;;
         -k|--kill)
diff --git a/tests/conftest.py b/tests/conftest.py
index ab46503f..9b91322e 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -48,18 +48,18 @@ def pytest_configure():
                 "NAME": db_name,
                 "HOST": "localhost",
                 # The following DB settings are only used for `postgresql` and `postgis`
-                "PORT": os.environ.get("PGPORT", ""),
-                "USER": os.environ.get("PGUSER", ""),
-                "PASSWORD": os.environ.get("PGPASSWORD", ""),
+                "PORT": os.environ.get("POSTGRES_PORT", ""),
+                "USER": os.environ.get("POSTGRES_USER", ""),
+                "PASSWORD": os.environ.get("POSTGRES_PASSWORD", ""),
             },
             # Extra DB used to test multi database support
             EXTRA_DB: {
                 "ENGINE": db_engine,
                 "NAME": extra_db_name,
                 "HOST": "localhost",
-                "PORT": os.environ.get("PGPORT", ""),
-                "USER": os.environ.get("PGUSER", ""),
-                "PASSWORD": os.environ.get("PGPASSWORD", ""),
+                "PORT": os.environ.get("POSTGRES_PORT", ""),
+                "USER": os.environ.get("POSTGRES_USER", ""),
+                "PASSWORD": os.environ.get("POSTGRES_PASSWORD", ""),
             },
         },
         INSTALLED_APPS=installed_apps,
diff --git a/tox.ini b/tox.ini
index 8595863a..7e49e989 100644
--- a/tox.ini
+++ b/tox.ini
@@ -18,7 +18,8 @@ python =
 setenv =
     PYTHONPATH={toxinidir}
     postgresql: TEST_DB=postgis
-    postgresql: PGUSER=postgres
+    postgresql: POSTGRES_USER=postgres
+    postgresql: POSTGRES_PASSWORD=postgres
     sqlite: TEST_DB=sqlite
     sqlite: USE_TZ=True
 deps =