Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The flight plan should surface unexpected statuses #2583

Closed
eggrobin opened this issue May 19, 2020 · 1 comment · Fixed by #2588
Closed

The flight plan should surface unexpected statuses #2583

eggrobin opened this issue May 19, 2020 · 1 comment · Fixed by #2588
Milestone

Comments

@eggrobin
Copy link
Member

The default

string remedy_message = "changing the flight plan"; // Preceded by "Try".
string status_message = "computation failed"; // Preceded by "The".

gets shown when the status is not one of ABORTED, FAILED_PRECONDITION, INVALID_ARGUMENT, or OUT_OF_RANGE.

This is not a useful message, and silently absorbing the unexpected message prevents us from diagnosing potential issues.

Encountered by Falcon on discord:
image

@eggrobin
Copy link
Member Author

I suspect the status here is DEADLINE_EXCEEDED (the ephemeris does not go all the way to the requested 8000 days).

I am not sure whether the current behaviour is such that we eventually compute the requested ephemeris, pushing it forward a little at each frame, or whether we ignore the issue until a modified flight plan is requested (the former would be the expected behaviour, and it is the behaviour for predictions; the error message should accordingly ask the user to wait for the prolongation of the ephemeris).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants