-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update root project for Angular 15 support #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI failed when trying to run these changes: https://github.com/mobxjs/mobx-angular/actions/runs/4234842254/jobs/7360174315
Side note: Can we get https://github.com/mobxjs/mobx-angular/blob/master/.github/workflows/main.yml updated to run the project unit tests / linting?
@sagarchikane looks like the build is failing https://github.com/mobxjs/mobx-angular/actions/runs/4242238682/jobs/7378030827 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skips execution of unit tests on example projects
The compare bundle sizes step is failing here as the |
Things taken care of as part of this PR
package.json
updates to support Angular 15 (Angular 16 release schedule) and latest Angular MaterialCUSTOM_ELEMENTS_SCHEMA
when running tests