Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mobx version #125

Closed
nicolidin opened this issue Oct 26, 2020 · 3 comments
Closed

New Mobx version #125

nicolidin opened this issue Oct 26, 2020 · 3 comments

Comments

@nicolidin
Copy link

nicolidin commented Oct 26, 2020

As Mobx is now in 6.0.1, this repository should add in the ReadMe and in the examples (should update mobx version) makeObservable(this) or makeAutoObservable(this) (if no decorators) in the constructor. If decorators is used "useDefineForClassFields": true should be added to in tsconfig.json too.

(if you validate I can create the pr)

@adamkleingit
Copy link
Member

True,
@nicolidin care to make a PR?
That would be very helpful for the repo and the community. Thanks!

@EVASIVE
Copy link
Contributor

EVASIVE commented Aug 4, 2021

@adamkleingit I am also faced with inconsistence of mobx-angular example and mobx documentation, so I created PR with these changes
#138

@SimonMcKinsey
Copy link
Member

Thanks @EVASIVE, This has been merged (#138).
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants